You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "WSYwsy22 (via GitHub)" <gi...@apache.org> on 2023/03/09 07:36:00 UTC

[GitHub] [rocketmq] WSYwsy22 commented on a diff in pull request #6262: [ISSUE #6268] fix rocketmq-proxy does not work properly in k8s nodePort mode

WSYwsy22 commented on code in PR #6262:
URL: https://github.com/apache/rocketmq/pull/6262#discussion_r1130590374


##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/route/RouteActivity.java:
##########
@@ -162,12 +161,11 @@ protected Permission convertToPermission(int perm) {
     }
 
     protected List<org.apache.rocketmq.proxy.common.Address> convertToAddressList(Endpoints endpoints) {
-        int port = ConfigurationManager.getProxyConfig().getGrpcServerPort();
         List<org.apache.rocketmq.proxy.common.Address> addressList = new ArrayList<>();
         for (Address address : endpoints.getAddressesList()) {
             addressList.add(new org.apache.rocketmq.proxy.common.Address(
                 org.apache.rocketmq.proxy.common.Address.AddressScheme.valueOf(endpoints.getScheme().name()),
-                HostAndPort.fromParts(address.getHost(), port))
+                HostAndPort.fromParts(address.getHost(), address.getPort()))

Review Comment:
   yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org