You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/10/11 23:26:15 UTC

[GitHub] flink pull request #4812: [FLINK-7540] Apply consistent hostname normalizati...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4812

    [FLINK-7540] Apply consistent hostname normalization

    ## What is the purpose of the change
    
    The hostname normalization is now applied when generating the remote akka config.
    That way it should be ensured that all ActorSystems are bound to a normalized
    hostname.
    
    ## Brief change log
    
    - Add hostname normalization to `AkkaUtils#getAkkaConfig`
    - Replace manual ActorSystem instantiation with `BootstrapTools#startActorSystem`
    
    ## Verifying this change
    
    - Added `AkkaUtilsTest#getAkkaConfig`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) It affects how `ActorSystem` are instantiated.
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixHostnameNormalization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4812
    
----
commit 00876ead7a4a7492d643f6cba3e784044c54669e
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-11T23:17:23Z

    [FLINK-7540] Apply consistent hostname normalization
    
    The hostname normalization is now applied when generationg the remote akka config.
    That way it should be ensured that all ActorSystems are bound to a normalized
    hostname.

----


---

[GitHub] flink issue #4812: [FLINK-7540] Apply consistent hostname normalization

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4812
  
    Thanks for the review @aljoscha. Rebasing and once Travis gives green light, I'll merge this PR.


---

[GitHub] flink issue #4812: [FLINK-7540] Apply consistent hostname normalization

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4812
  
    These changes look good! 👍 
    
    And the code is even simplified by using a common method for creating the actor system.


---

[GitHub] flink pull request #4812: [FLINK-7540] Apply consistent hostname normalizati...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4812


---