You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/02/23 08:37:01 UTC
[jira] [Commented] (IMPALA-10536) saml2_callback_token_ttl's unit
is seconds instead of milliseconds
[ https://issues.apache.org/jira/browse/IMPALA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288938#comment-17288938 ]
ASF subversion and git services commented on IMPALA-10536:
----------------------------------------------------------
Commit 15fd8c92a80817158a900dab8e1da1d64f47f9a8 in impala's branch refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=15fd8c9 ]
IMPALA-10536: Fix saml2_callback_token_ttl's description
The unit in the description of saml2_callback_token_ttl was
"seconds", while its value is interpreted as milliseconds and
the default 30 was way too low. Changing the description to
mention milliseconds.
Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8
Reviewed-on: http://gerrit.cloudera.org:8080/17107
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
> saml2_callback_token_ttl's unit is seconds instead of milliseconds
> ------------------------------------------------------------------
>
> Key: IMPALA-10536
> URL: https://issues.apache.org/jira/browse/IMPALA-10536
> Project: IMPALA
> Issue Type: Bug
> Reporter: Csaba Ringhofer
> Priority: Major
>
> The description of saml2_callback_token_ttl writes "seconds", while its value is interpreted as milliseconds, which the default 30 is way too short outside automatic tests.
> I think that keeping the semantics and just rewriting the desc to milliseconds is better than fixing the semantics, because the very low ttl is actually useful for automatic tests that test expiration logic.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org