You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/08/09 04:45:33 UTC

[arrow] branch master updated: ARROW-3026: [Python] [Plasma] Only run Plasma unit tests with valgrind under Python 3.6

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 6e5bfe2  ARROW-3026: [Python] [Plasma] Only run Plasma unit tests with valgrind under Python 3.6
6e5bfe2 is described below

commit 6e5bfe272c5a7e061c00299e1404e0fea84031e3
Author: Wes McKinney <we...@apache.org>
AuthorDate: Thu Aug 9 00:45:29 2018 -0400

    ARROW-3026: [Python] [Plasma] Only run Plasma unit tests with valgrind under Python 3.6
    
    These tests are time consuming, and memory leaks are likely to be present in both builds if there are any.
    
    cc @pcmoritz @robertnishihara @pitrou
    
    Author: Wes McKinney <we...@apache.org>
    
    Closes #2407 from wesm/ARROW-3026 and squashes the following commits:
    
    abd4a0f1 <Wes McKinney> Try again in slightly different way, add debug print
    d61b234d <Wes McKinney> Try something else
    2f0c9b32 <Wes McKinney> Only run Plasma unit tests with valgrind under Python 3.6
---
 .travis.yml                | 4 ++++
 ci/travis_script_python.sh | 4 +---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index f8f96ac..940a960 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -80,7 +80,11 @@ matrix:
     - $TRAVIS_BUILD_DIR/ci/travis_build_parquet_cpp.sh
     # Build Arrow Java to test the pyarrow<->JVM in-process bridge
     - $TRAVIS_BUILD_DIR/ci/travis_script_java.sh
+    # Only run Plasma tests with valgrind in one of the Python builds because
+    # they are slow
+    - export PLASMA_VALGRIND=0
     - $TRAVIS_BUILD_DIR/ci/travis_script_python.sh 2.7
+    - export PLASMA_VALGRIND=1
     - $TRAVIS_BUILD_DIR/ci/travis_script_python.sh 3.6
     - $TRAVIS_BUILD_DIR/ci/travis_upload_cpp_coverage.sh
   # [OS X] C++ & Python w/ XCode 6.4
diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh
index 53dd36c..ebdd5de 100755
--- a/ci/travis_script_python.sh
+++ b/ci/travis_script_python.sh
@@ -124,9 +124,7 @@ python -c "import pyarrow.parquet"
 python -c "import pyarrow.plasma"
 python -c "import pyarrow.orc"
 
-if [ "$ARROW_TRAVIS_VALGRIND" == "1" ]; then
-  export PLASMA_VALGRIND=1
-fi
+echo "PLASMA_VALGRIND: $PLASMA_VALGRIND"
 
 # Set up huge pages for plasma test
 if [ $TRAVIS_OS_NAME == "linux" ]; then