You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by jo...@apache.org on 2008/12/02 20:55:15 UTC
svn commit: r722590 - /incubator/shindig/trunk/features/core/legacy.js
Author: johnh
Date: Tue Dec 2 11:55:15 2008
New Revision: 722590
URL: http://svn.apache.org/viewvc?rev=722590&view=rev
Log:
Legacy caching APIs support refreshInterval.
Modified:
incubator/shindig/trunk/features/core/legacy.js
Modified: incubator/shindig/trunk/features/core/legacy.js
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/core/legacy.js?rev=722590&r1=722589&r2=722590&view=diff
==============================================================================
--- incubator/shindig/trunk/features/core/legacy.js (original)
+++ incubator/shindig/trunk/features/core/legacy.js Tue Dec 2 11:55:15 2008
@@ -98,11 +98,15 @@
}, params);
}
-function _IG_GetCachedUrl(url) {
- return gadgets.io.getProxyUrl(url);
+function _IG_GetCachedUrl(url, opt_params) {
+ var params = { 'REFRESH_INTERVAL': 3600 };
+ if (opt_params && opt_params.refreshInterval) {
+ params['REFRESH_INTERVAL'] = opt_params.refreshInterval;
+ }
+ return gadgets.io.getProxyUrl(url, params);
}
-function _IG_GetImageUrl(url) {
- return gadgets.io.getProxyUrl(url);
+function _IG_GetImageUrl(url, opt_params) {
+ return _IG_GetCachedUrl(url, opt_params);
}
function _IG_GetImage(url) {
var img = document.createElement('img');
Re: svn commit: r722590 - /incubator/shindig/trunk/features/core/legacy.js
Posted by John Hjelmstad <fa...@google.com>.
I should have been less lazy to begin with. ;) Patched.
On Tue, Dec 2, 2008 at 12:47 PM, Henning P. Schmiedehausen <
henning@schmiedehausen.org> wrote:
> John Hjelmstad <fa...@google.com> writes:
>
> >> Can we get that patch into the release branch, too?
>
> >Are you asking if I see a problem w/ that, or if I'll do it, or both? :)
>
> If you don't see a problem, please apply it to the release branch, too. :-)
> (Yes, please do it).
>
> Ciao
> Henning
>
> --
> Henning P. Schmiedehausen - Palo Alto, California, U.S.A.
> henning@schmiedehausen.org "We're Germans and we use Unix.
> henning@apache.org That's a combination of two demographic groups
> known to have no sense of humour whatsoever."
> -- Hanno Mueller, de.comp.os.unix.programming
>
Re: svn commit: r722590 - /incubator/shindig/trunk/features/core/legacy.js
Posted by "Henning P. Schmiedehausen" <he...@schmiedehausen.org>.
John Hjelmstad <fa...@google.com> writes:
>> Can we get that patch into the release branch, too?
>Are you asking if I see a problem w/ that, or if I'll do it, or both? :)
If you don't see a problem, please apply it to the release branch, too. :-) (Yes, please do it).
Ciao
Henning
--
Henning P. Schmiedehausen - Palo Alto, California, U.S.A.
henning@schmiedehausen.org "We're Germans and we use Unix.
henning@apache.org That's a combination of two demographic groups
known to have no sense of humour whatsoever."
-- Hanno Mueller, de.comp.os.unix.programming
Re: svn commit: r722590 - /incubator/shindig/trunk/features/core/legacy.js
Posted by John Hjelmstad <fa...@google.com>.
On Tue, Dec 2, 2008 at 12:27 PM, Henning P. Schmiedehausen <
henning@schmiedehausen.org> wrote:
> johnh@apache.org writes:
>
> >Author: johnh
> >Date: Tue Dec 2 11:55:15 2008
> >New Revision: 722590
>
> >URL: http://svn.apache.org/viewvc?rev=722590&view=rev
> >Log:
> >Legacy caching APIs support refreshInterval.
>
>
> >Modified:
> > incubator/shindig/trunk/features/core/legacy.js
>
> Can we get that patch into the release branch, too?
Are you asking if I see a problem w/ that, or if I'll do it, or both? :)
>
>
> Ciao
> Henning
>
> --
> Henning P. Schmiedehausen - Palo Alto, California, U.S.A.
> henning@schmiedehausen.org "We're Germans and we use Unix.
> henning@apache.org That's a combination of two demographic groups
> known to have no sense of humour whatsoever."
> -- Hanno Mueller, de.comp.os.unix.programming
>
Re: svn commit: r722590 - /incubator/shindig/trunk/features/core/legacy.js
Posted by "Henning P. Schmiedehausen" <he...@schmiedehausen.org>.
johnh@apache.org writes:
>Author: johnh
>Date: Tue Dec 2 11:55:15 2008
>New Revision: 722590
>URL: http://svn.apache.org/viewvc?rev=722590&view=rev
>Log:
>Legacy caching APIs support refreshInterval.
>Modified:
> incubator/shindig/trunk/features/core/legacy.js
Can we get that patch into the release branch, too?
Ciao
Henning
--
Henning P. Schmiedehausen - Palo Alto, California, U.S.A.
henning@schmiedehausen.org "We're Germans and we use Unix.
henning@apache.org That's a combination of two demographic groups
known to have no sense of humour whatsoever."
-- Hanno Mueller, de.comp.os.unix.programming