[GitHub] [spark] Ngone51 commented on a change in pull request #24699: [SPARK-27666][CORE] Stop PythonRunner's WriteThread immediately when task finishes

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #24699: [SPARK-27666][CORE] Stop PythonRunner's WriteThread immediately when task finishes
URL: https://github.com/apache/spark/pull/24699#discussion_r287555855
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala
 ##########
 @@ -180,6 +180,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
     def shutdownOnTaskCompletion() {
       assert(context.isCompleted)
       this.interrupt()
+      this.join()
 
 Review comment:
   Hi, @viirya. Can you explain more about 'deadlock' please ? I just notice that it's possible we fall into deadlock if WritedThread trying to acquire lock on TaskContext after `this.join()` invoked, but I haven't found where it did happens.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org