You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/20 10:17:37 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #20784: fix: core coverage
zhaoyongjie opened a new pull request, #20784:
URL: https://github.com/apache/superset/pull/20784
### SUMMARY
bring 100% code coverage to the `superset-ui/core`. this PR should wait for [this to merge](https://github.com/apache/superset/pull/20769).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20784: fix: core coverage
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20784:
URL: https://github.com/apache/superset/pull/20784#discussion_r925435641
##########
superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts:
##########
@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [
},
];
-export const isValidDatasourceType = (datasource: DatasourceType) =>
Review Comment:
This function is unused. a more readable expression is `'Table' in DatasourceType`.
##########
superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts:
##########
@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [
},
];
-export const isValidDatasourceType = (datasource: DatasourceType) =>
Review Comment:
This function is unuse, a more readable expression is `'Table' in DatasourceType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20784: fix: core coverage and add a coverage step in workflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20784:
URL: https://github.com/apache/superset/pull/20784#issuecomment-1190133212
# [Codecov](https://codecov.io/gh/apache/superset/pull/20784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20784](https://codecov.io/gh/apache/superset/pull/20784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e200041) into [master](https://codecov.io/gh/apache/superset/commit/bb5b8e4c4fee04084944d399bee9dfa278f20177?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb5b8e4) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head e200041 differs from pull request most recent head 8387448. Consider uploading reports for the commit 8387448 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20784 +/- ##
=======================================
Coverage 66.30% 66.30%
=======================================
Files 1756 1756
Lines 66737 66735 -2
Branches 7049 7049
=======================================
+ Hits 44247 44251 +4
+ Misses 20693 20688 -5
+ Partials 1797 1796 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.93% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ges/superset-ui-core/src/query/types/Datasource.ts](https://codecov.io/gh/apache/superset/pull/20784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvRGF0YXNvdXJjZS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/20784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `91.60% <0.00%> (+0.36%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/20784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `94.38% <0.00%> (+0.51%)` | :arrow_up: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/20784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `93.50% <0.00%> (+1.29%)` | :arrow_up: |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/20784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `89.28% <0.00%> (+3.57%)` | :arrow_up: |
| [...ckages/superset-ui-core/src/query/DatasourceKey.ts](https://codecov.io/gh/apache/superset/pull/20784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvRGF0YXNvdXJjZUtleS50cw==) | `100.00% <0.00%> (+16.66%)` | :arrow_up: |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20784: fix: core coverage
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20784:
URL: https://github.com/apache/superset/pull/20784#discussion_r925435641
##########
superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts:
##########
@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [
},
];
-export const isValidDatasourceType = (datasource: DatasourceType) =>
Review Comment:
this function is unused. a more readable expression is `'Table' in DatasourceType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #20784: fix: core coverage and add a coverage step in workflow
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #20784:
URL: https://github.com/apache/superset/pull/20784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20784: fix: core coverage and add a coverage step in workflow
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20784:
URL: https://github.com/apache/superset/pull/20784#discussion_r925435641
##########
superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts:
##########
@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [
},
];
-export const isValidDatasourceType = (datasource: DatasourceType) =>
Review Comment:
This function is unused, a more readable expression is `'Table' in DatasourceType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org