You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:18:10 UTC

[GitHub] [skywalking-banyandb-java-client] hanahmily commented on a diff in pull request #30: Remove Measure ID

hanahmily commented on code in PR #30:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/30#discussion_r1061424014


##########
src/main/java/org/apache/skywalking/banyandb/v1/client/MeasureWrite.java:
##########
@@ -52,10 +51,6 @@ public MeasureWrite tag(String tagName, Serializable<BanyandbModel.TagValue> tag
         return (MeasureWrite) super.tag(tagName, tagValue);
     }
 
-    public MeasureWrite setID(String idValue) throws BanyanDBException {
-        return this.tag(Measure.ID, TagAndValue.idTagValue(idValue));

Review Comment:
   Make sense. The ID type means nothing anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org