You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/10/30 02:34:34 UTC
[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #146: Restore documented RollingFileAppender configuration properties
swebb2066 opened a new pull request, #146:
URL: https://github.com/apache/logging-log4cxx/pull/146
Removing support for the [documented](https://logging.apache.org/log4cxx/latest_stable/usage.html#configuration) MaxBackupIndex amd MaxFileSize configuration options in a .properties file would cause too much grief when users upgrade log4cxx.
The usage documentation has a configuration example that includes the following
log4j.appender.R.maxFileSize=100 log4j.appender.R.maxBackupIndex=3
This PR restores the 0.13 RollingFileAppender behaviour (which was implemented in a file named "obsoleterollingfileappender.cpp" by Curt Arnold in 2005 when he migrated to Apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #146: Restore documented RollingFileAppender configuration properties
Posted by GitBox <gi...@apache.org>.
rm5248 commented on PR #146:
URL: https://github.com/apache/logging-log4cxx/pull/146#issuecomment-1298341595
Would it make more sense to update the documentation instead of re-adding in properties that are effectively obsolete? Even if we do keep this for compatibility reasons, we should probably update the documentation and examples; there is currently only somewhat limited documentation within the [RollingFileAppender class](https://logging.apache.org/log4cxx/latest_stable/classlog4cxx_1_1rolling_1_1RollingFileAppender.html) giving an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 merged pull request #146: Restore documented RollingFileAppender configuration properties
Posted by GitBox <gi...@apache.org>.
swebb2066 merged PR #146:
URL: https://github.com/apache/logging-log4cxx/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org