You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/19 16:51:03 UTC
[GitHub] [airflow] turbaszek opened a new pull request #8454: Remove
unittest.main() from tests
turbaszek opened a new pull request #8454: Remove unittest.main() from tests
URL: https://github.com/apache/airflow/pull/8454
Since we've never used `unittest` those `main` clauses are misleading.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #8454: Remove
unittest.main() from tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8454: Remove unittest.main() from tests
URL: https://github.com/apache/airflow/pull/8454#issuecomment-616192452
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=h1) Report
> Merging [#8454](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11454cb759d3d58464586e50cbfbbefb1c39133c&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8454 +/- ##
======================================
Coverage 6.22% 6.23%
======================================
Files 946 946
Lines 45665 45665
======================================
+ Hits 2844 2846 +2
+ Misses 42821 42819 -2
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8454/diff?src=pr&el=tree#diff-YWlyZmxvdy9fX2luaXRfXy5weQ==) | `69.56% <0.00%> (+8.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=footer). Last update [11454cb...111ae5c](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8454: Remove
unittest.main() from tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8454: Remove unittest.main() from tests
URL: https://github.com/apache/airflow/pull/8454#issuecomment-616192452
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=h1) Report
> Merging [#8454](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11454cb759d3d58464586e50cbfbbefb1c39133c&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8454 +/- ##
======================================
Coverage 6.22% 6.23%
======================================
Files 946 946
Lines 45665 45665
======================================
+ Hits 2844 2846 +2
+ Misses 42821 42819 -2
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8454/diff?src=pr&el=tree#diff-YWlyZmxvdy9fX2luaXRfXy5weQ==) | `69.56% <0.00%> (+8.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=footer). Last update [11454cb...111ae5c](https://codecov.io/gh/apache/airflow/pull/8454?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8454: Remove unittest.main()
from tests
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8454: Remove unittest.main() from tests
URL: https://github.com/apache/airflow/pull/8454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services