You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/07 07:33:02 UTC
[GitHub] [skywalking-satellite] EvanLjp opened a new pull request #37: fix some bugs in Satellite
EvanLjp opened a new pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37
fix some bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608469277
##########
File path: docs/en/concepts-and-designs/mmap-queue.md
##########
@@ -41,12 +41,12 @@ goos: darwin
goarch: amd64
pkg: github.com/apache/skywalking-satellite/plugins/queue/mmap
BenchmarkEnqueue
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:18_message:8KB_queueCapacity:10000 10000 106520 ns/op 9888 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:10_message:8KB_queueCapacity:10000 18536 54331 ns/op 9839 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_512KB_maxInMemSegments:6_message:8KB_queueCapacity:10000 27859 43251 ns/op 9815 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:20_message:8KB_queueCapacity:10000 23673 45910 ns/op 9839 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:16KB_queueCapacity:10000 10000 131686 ns/op 18941 B/op 10 allocs/op
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:8KB_queueCapacity:100000 23011 47101 ns/op 9887 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:18_message:8KB_queueCapacity:10000 27585 43559 ns/op 9889 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:10_message:8KB_queueCapacity:10000 39326 31773 ns/op 9840 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_512KB_maxInMemSegments:6_message:8KB_queueCapacity:10000 56770 22990 ns/op 9816 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:20_message:8KB_queueCapacity:10000 43803 29778 ns/op 9840 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:16KB_queueCapacity:10000 16870 80576 ns/op 18944 B/op 10 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:8KB_queueCapacity:100000 36922 39085 ns/op 9889 B/op 9 allocs/op
Review comment:
Whoo, I can see a big improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608471025
##########
File path: CHANGES.md
##########
@@ -2,25 +2,15 @@ Changes by Version
==================
Release Notes.
-0.1.0
+0.2.0
------------------
#### Features
-* Build the Satellite core structure.
-* Add prometheus self telemetry.
-* Add kafka client plugin.
-* Add none-fallbacker plugin.
-* Add timer-fallbacker plugin.
-* Add nativelog-kafka-forwarder plugin.
-* Add memory-queue plugin.
-* Add mmap-queue plugin.
-* Add grpc-nativelog-receiver plugin.
-* Add http-nativelog-receiver plugin.
-* Add grpc-server plugin.
-* Add http-server plugin.
-* Add prometheus-server plugin.
+
#### Bug Fixes
+Fix the data race in mmap queue.
+Fix channel blocking in sender module.
Review comment:
I think you upgrade the protocol dependency, no description here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #37: fix data race in mmap & fix blocking channel in sender
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#issuecomment-814741977
> > fix some bugs
>
> Please explain the bug. Typically, you should not mix different things in one PR.
I'll pay attention next time, I found the blocking bug when testing the new locker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608470407
##########
File path: docs/en/concepts-and-designs/mmap-queue.md
##########
@@ -41,12 +41,12 @@ goos: darwin
goarch: amd64
pkg: github.com/apache/skywalking-satellite/plugins/queue/mmap
BenchmarkEnqueue
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:18_message:8KB_queueCapacity:10000 10000 106520 ns/op 9888 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:10_message:8KB_queueCapacity:10000 18536 54331 ns/op 9839 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_512KB_maxInMemSegments:6_message:8KB_queueCapacity:10000 27859 43251 ns/op 9815 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:20_message:8KB_queueCapacity:10000 23673 45910 ns/op 9839 B/op 9 allocs/op
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:16KB_queueCapacity:10000 10000 131686 ns/op 18941 B/op 10 allocs/op
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:8KB_queueCapacity:100000 23011 47101 ns/op 9887 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:18_message:8KB_queueCapacity:10000 27585 43559 ns/op 9889 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:10_message:8KB_queueCapacity:10000 39326 31773 ns/op 9840 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_512KB_maxInMemSegments:6_message:8KB_queueCapacity:10000 56770 22990 ns/op 9816 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:20_message:8KB_queueCapacity:10000 43803 29778 ns/op 9840 B/op 9 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:16KB_queueCapacity:10000 16870 80576 ns/op 18944 B/op 10 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:8KB_queueCapacity:100000 36922 39085 ns/op 9889 B/op 9 allocs/op
Review comment:
yes, the new locker would only lock one segment rather than whole segments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608471421
##########
File path: CHANGES.md
##########
@@ -2,25 +2,15 @@ Changes by Version
==================
Release Notes.
-0.1.0
+0.2.0
Review comment:
We usually keep all versions' changelogs. Check the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608468849
##########
File path: CHANGES.md
##########
@@ -2,25 +2,15 @@ Changes by Version
==================
Release Notes.
-0.1.0
+0.2.0
Review comment:
Where do you put the previous changelog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #37: fix data race in mmap & fix blocking channel in sender
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608478729
##########
File path: CHANGES.md
##########
@@ -2,25 +2,15 @@ Changes by Version
==================
Release Notes.
-0.1.0
+0.2.0
Review comment:
https://github.com/apache/skywalking-satellite/blob/fix-race-bug/changes/changes-0.1.0.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#issuecomment-814738364
> fix some bugs
Please explain the bug. Typically, you should not mix different things in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #37: fix data race in mmap & fix blocking channel in sender
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #37: fix data race in mmap & fix blocking channel in sender
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608477560
##########
File path: CHANGES.md
##########
@@ -2,25 +2,15 @@ Changes by Version
==================
Release Notes.
-0.1.0
+0.2.0
Review comment:
yes, already keeps it. I don't remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #37: fix some bugs in Satellite
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-satellite/pull/37#discussion_r608470969
##########
File path: CHANGES.md
##########
@@ -2,25 +2,15 @@ Changes by Version
==================
Release Notes.
-0.1.0
+0.2.0
Review comment:
https://github.com/apache/skywalking-satellite/blob/v0.1.0/changes/changes-0.1.0.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org