[GitHub] [superset] rusackas commented on a diff in pull request #19881: feat(world-map): support color by metric or country column

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19881:
URL: https://github.com/apache/superset/pull/19881#discussion_r861365614


##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx:
##########
@@ -53,8 +53,12 @@ export default function RadioButtonControl({
         '.btn:focus': {
           outline: 'none',
         },
+        '.control-label': {
+          color: theme.colors.grayscale.base,
+          marginBottom: theme.gridUnit,
+        },
         '.control-label + .btn-group': {
-          marginTop: 1,
+          marginTop: theme.gridUnit * 0.25,

Review Comment:
   I think it's fine to avoid fractional gridUnits, and just use 1px in this case.... if it's even needed at all. 
   ```suggestion
             marginTop:  1px,
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org