You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bill Farner <wf...@apache.org> on 2014/06/20 22:06:30 UTC
Review Request 22837: Expose constructors for types declared in Log.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1519
https://issues.apache.org/jira/browse/MESOS-1519
Repository: mesos-git
Description
-------
This allows java API users to construct objects in tests without extra hoop-jumping.
I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
Diffs
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
Diff: https://reviews.apache.org/r/22837/diff/
Testing
-------
$ make
$ make check
Thanks,
Bill Farner
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by Bill Farner <wf...@apache.org>.
> On June 20, 2014, 9:37 p.m., Jie Yu wrote:
> > src/java/src/org/apache/mesos/Log.java, lines 78-81
> > <https://reviews.apache.org/r/22837/diff/1/?file=614348#file614348line78>
> >
> > Can you add a comment here saying that this constructor is supposed to be used only in test?
Done.
> On June 20, 2014, 9:37 p.m., Jie Yu wrote:
> > src/java/src/org/apache/mesos/Log.java, lines 94-100
> > <https://reviews.apache.org/r/22837/diff/1/?file=614348#file614348line94>
> >
> > Ditto.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/#review46327
-----------------------------------------------------------
On June 23, 2014, 9:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22837/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 9:04 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1519
> https://issues.apache.org/jira/browse/MESOS-1519
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows java API users to construct objects in tests without extra hoop-jumping.
>
> I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/22837/diff/
>
>
> Testing
> -------
>
> $ make
> $ make check
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/#review46327
-----------------------------------------------------------
Ship it!
src/java/src/org/apache/mesos/Log.java
<https://reviews.apache.org/r/22837/#comment81651>
Can you add a comment here saying that this constructor is supposed to be used only in test?
src/java/src/org/apache/mesos/Log.java
<https://reviews.apache.org/r/22837/#comment81652>
Ditto.
- Jie Yu
On June 20, 2014, 8:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22837/
> -----------------------------------------------------------
>
> (Updated June 20, 2014, 8:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1519
> https://issues.apache.org/jira/browse/MESOS-1519
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows java API users to construct objects in tests without extra hoop-jumping.
>
> I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/22837/diff/
>
>
> Testing
> -------
>
> $ make
> $ make check
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/
-----------------------------------------------------------
(Updated June 23, 2014, 9:04 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-1519
https://issues.apache.org/jira/browse/MESOS-1519
Repository: mesos-git
Description
-------
This allows java API users to construct objects in tests without extra hoop-jumping.
I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
Diff: https://reviews.apache.org/r/22837/diff/
Testing
-------
$ make
$ make check
Thanks,
Bill Farner
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by Bill Farner <wf...@apache.org>.
> On June 20, 2014, 8:54 p.m., John Sirois wrote:
> > src/java/src/org/apache/mesos/Log.java, line 36
> > <https://reviews.apache.org/r/22837/diff/1/?file=614348#file614348line36>
> >
> > It seems like this should go too.
> > Any use getting one from the real driver will be doing so through a driver-dependent class that actually needs to have a native load. Here there are no native bits in-play at all fwict.
I agree in practice, but if some hypothetical person wanted to use the log independent of the rest of mesos (which seems possible as-is), wouldn't they be broken by that change?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/#review46320
-----------------------------------------------------------
On June 20, 2014, 8:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22837/
> -----------------------------------------------------------
>
> (Updated June 20, 2014, 8:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1519
> https://issues.apache.org/jira/browse/MESOS-1519
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows java API users to construct objects in tests without extra hoop-jumping.
>
> I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/22837/diff/
>
>
> Testing
> -------
>
> $ make
> $ make check
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by John Sirois <jo...@gmail.com>.
> On June 20, 2014, 2:54 p.m., John Sirois wrote:
> > src/java/src/org/apache/mesos/Log.java, line 36
> > <https://reviews.apache.org/r/22837/diff/1/?file=614348#file614348line36>
> >
> > It seems like this should go too.
> > Any use getting one from the real driver will be doing so through a driver-dependent class that actually needs to have a native load. Here there are no native bits in-play at all fwict.
>
> Bill Farner wrote:
> I agree in practice, but if some hypothetical person wanted to use the log independent of the rest of mesos (which seems possible as-is), wouldn't they be broken by that change?
Yeah - my bad. I failed to expand the bottom context and though this was just Position and Entry.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/#review46320
-----------------------------------------------------------
On June 23, 2014, 3:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22837/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 3:04 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1519
> https://issues.apache.org/jira/browse/MESOS-1519
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows java API users to construct objects in tests without extra hoop-jumping.
>
> I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/22837/diff/
>
>
> Testing
> -------
>
> $ make
> $ make check
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/#review46320
-----------------------------------------------------------
src/java/src/org/apache/mesos/Log.java
<https://reviews.apache.org/r/22837/#comment81644>
It seems like this should go too.
Any use getting one from the real driver will be doing so through a driver-dependent class that actually needs to have a native load. Here there are no native bits in-play at all fwict.
- John Sirois
On June 20, 2014, 2:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22837/
> -----------------------------------------------------------
>
> (Updated June 20, 2014, 2:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1519
> https://issues.apache.org/jira/browse/MESOS-1519
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows java API users to construct objects in tests without extra hoop-jumping.
>
> I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/22837/diff/
>
>
> Testing
> -------
>
> $ make
> $ make check
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22837: Expose constructors for types declared in Log.java
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22837/
-----------------------------------------------------------
(Updated June 20, 2014, 8:44 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
i'll let jie shepherd this -- @vinodkone
Bugs: MESOS-1519
https://issues.apache.org/jira/browse/MESOS-1519
Repository: mesos-git
Description
-------
This allows java API users to construct objects in tests without extra hoop-jumping.
I also unintentionally built with java 8, which pointed out some javadoc errors. I've fixed those here.
Diffs
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/SchedulerDriver.java 591984e66e8eca18f08d719659f325c21f63c2ba
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
Diff: https://reviews.apache.org/r/22837/diff/
Testing
-------
$ make
$ make check
Thanks,
Bill Farner