You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/21 05:25:08 UTC

[GitHub] [incubator-devlake] Pranshu-Raj opened a new issue, #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling

Pranshu-Raj opened a new issue, #2561:
URL: https://github.com/apache/incubator-devlake/issues/2561

   Missing error handling in GET GET /plugins/gitlab/connections/connectionId
   Missing error handling in GET GET /plugins/jenkins/connections/connectionId
   Missing error handling in GET GET /plugins/jira/connections/connectionId
   Missing error handling in GET GET /plugins/tapd/connections/connectionId
   
   To fix the error handling part {missing: if err != nil {
   return nil, err
   }}


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2561:
URL: https://github.com/apache/incubator-devlake/issues/2561#issuecomment-1221654983

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mappjzc commented on issue #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling

Posted by GitBox <gi...@apache.org>.
mappjzc commented on issue #2561:
URL: https://github.com/apache/incubator-devlake/issues/2561#issuecomment-1192094601

   Thanks for reporting the issue. I'm looking forward to your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2561:
URL: https://github.com/apache/incubator-devlake/issues/2561#issuecomment-1229595437

   This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mappjzc commented on issue #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling

Posted by GitBox <gi...@apache.org>.
mappjzc commented on issue #2561:
URL: https://github.com/apache/incubator-devlake/issues/2561#issuecomment-1192117549

   ![image](https://user-images.githubusercontent.com/2921251/180344964-5c5ea14c-dd23-4903-a8cb-b2647c781cfc.png)
   I have finished to looking forward to your PR.
   The err has been return  whether it is empty or not.
   
   You can changed the code as
   ```
   if err != nil {
       return nil,err
   }
   return &core.ApiResourceOutput{Body: connection}, nil
   ```
   and update your pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] closed issue #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #2561: [Refactor][gitlab,jira,jenkins,tapd] Missing error handling
URL: https://github.com/apache/incubator-devlake/issues/2561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org