You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zhhyu7 (via GitHub)" <gi...@apache.org> on 2023/05/05 07:21:49 UTC
[GitHub] [nuttx] zhhyu7 opened a new pull request, #9195: icmpv6: add SOCK_RAW type support
zhhyu7 opened a new pull request, #9195:
URL: https://github.com/apache/nuttx/pull/9195
The third-party library we are porting will send and receive ICMPV6 messages (router_advert / router_solicit / neighbor_advert / neighbor_solicit etc.) from the user space itself, so we added the SOCK_RAW related implementation for ICMPV6.
## Summary
## Impact
## Testing
sim:local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9195: icmpv6: add SOCK_RAW type support
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9195:
URL: https://github.com/apache/nuttx/pull/9195#discussion_r1186457284
##########
net/icmpv6/icmpv6.h:
##########
@@ -97,13 +97,19 @@ struct icmpv6_conn_s
*/
struct iob_queue_s readahead; /* Read-ahead buffering */
+ struct icmp6_filter filter; /* ICMP6 type filter */
Review Comment:
@acassis because icmp6_filter is public struct defined by FreeBSD/Linux, just like you can't change pthread_t to pthread_s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9195: icmpv6: add SOCK_RAW type support
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9195:
URL: https://github.com/apache/nuttx/pull/9195#discussion_r1186457284
##########
net/icmpv6/icmpv6.h:
##########
@@ -97,13 +97,19 @@ struct icmpv6_conn_s
*/
struct iob_queue_s readahead; /* Read-ahead buffering */
+ struct icmp6_filter filter; /* ICMP6 type filter */
Review Comment:
@acassis because icmp6_filter is public struct defined by FreeBSD/Linux, all code which use raw socket will break(just like you can't change pthread_t to pthread_s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #9195: icmpv6: add SOCK_RAW type support
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #9195:
URL: https://github.com/apache/nuttx/pull/9195#discussion_r1186514966
##########
net/icmpv6/icmpv6.h:
##########
@@ -97,13 +97,19 @@ struct icmpv6_conn_s
*/
struct iob_queue_s readahead; /* Read-ahead buffering */
+ struct icmp6_filter filter; /* ICMP6 type filter */
Review Comment:
Understood, thank you @xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9195: icmpv6: add SOCK_RAW type support
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9195:
URL: https://github.com/apache/nuttx/pull/9195#discussion_r1186457284
##########
net/icmpv6/icmpv6.h:
##########
@@ -97,13 +97,19 @@ struct icmpv6_conn_s
*/
struct iob_queue_s readahead; /* Read-ahead buffering */
+ struct icmp6_filter filter; /* ICMP6 type filter */
Review Comment:
Because icmp6_filter is public struct defined by FreeBSD/Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #9195: icmpv6: add SOCK_RAW type support
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #9195:
URL: https://github.com/apache/nuttx/pull/9195#discussion_r1186414653
##########
net/icmpv6/icmpv6.h:
##########
@@ -97,13 +97,19 @@ struct icmpv6_conn_s
*/
struct iob_queue_s readahead; /* Read-ahead buffering */
+ struct icmp6_filter filter; /* ICMP6 type filter */
Review Comment:
Question: why `icmp6_filter` is not defined as `icmp6_filter_s` since it is a struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9195: icmpv6: add SOCK_RAW type support
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9195:
URL: https://github.com/apache/nuttx/pull/9195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org