You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/10 03:10:27 UTC
[GitHub] [flink] pyscala opened a new pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala opened a new pull request #12566:
URL: https://github.com/apache/flink/pull/12566
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
## Brief change log
Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
`private final static Integer DEFAULT_CAPACITY = 10000;
public FutureCompletingBlockingQueue(FutureNotifier futureNotifier) {
this(futureNotifier, DEFAULT_CAPACITY);
}
public FutureCompletingBlockingQueue(FutureNotifier futureNotifier, int capacity) {
super(capacity);
this.futureNotifier = futureNotifier;
}`
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (no), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4086eac47b36d124dd13d8a15261bcc823b89e74 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 887856985088fccc500f51a7ffc00dc8f619aeef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127)
* c607aaed98c957173a95039f7da9df99143b21c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-650900201
@pyscala Thanks for the patch. LGTM. Can we add a unit test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
}, {
"hash" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121",
"triggerID" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"triggerType" : "PUSH"
}, {
"hash" : "46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7bac4fab3223f42d461d122658e87f541b3b042 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121)
* 46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on a change in pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on a change in pull request #12566:
URL: https://github.com/apache/flink/pull/12566#discussion_r447413463
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/synchronization/FutureCompletingBlockingQueueTest.java
##########
@@ -0,0 +1,22 @@
+package org.apache.flink.connector.base.source.reader.synchronization;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
Review comment:
@becketqin Thanks for your detail guidance . I will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4086eac47b36d124dd13d8a15261bcc823b89e74 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118)
* 887856985088fccc500f51a7ffc00dc8f619aeef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
}, {
"hash" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c607aaed98c957173a95039f7da9df99143b21c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115)
* c7bac4fab3223f42d461d122658e87f541b3b042 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4086eac47b36d124dd13d8a15261bcc823b89e74 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118)
* 887856985088fccc500f51a7ffc00dc8f619aeef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12566:
URL: https://github.com/apache/flink/pull/12566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
}, {
"hash" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121",
"triggerID" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"triggerType" : "PUSH"
}, {
"hash" : "46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4128",
"triggerID" : "46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
}, {
"hash" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121",
"triggerID" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"triggerType" : "PUSH"
}, {
"hash" : "46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4128",
"triggerID" : "46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7bac4fab3223f42d461d122658e87f541b3b042 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121)
* 46d45cf0fe8cfc6966b7b4c8cf2649958a3e560b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-654045783
@JingsongLi @wuchong Can you review this PR for me? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641693599
Hi @becketqin ,appreciate for your time to review this PR,thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-654058889
> Thanks for the contribution. Why default value is 10000? Why not keep Int.Max?
@JingsongLi Thanks for your reply , The details link https://issues.apache.org/jira/browse/FLINK-17761 .
FutureCompletingBlockingQueue is a LinkedBlockingQueue and it is created using the default constructor, so its depth is
Integer.MAX_VALUE. So for a FetchTask to be blocked on a put(), it means that the queue is full so it has
Integer.MAX_VALUE elements already . Integer.MAX_VALUE is too large . I changed the default value to 10000 with @becketqin agree. At the same time, a construction method with capacity parameter is added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-654051068
Thanks for the contribution. Why default value is 10000? Why not keep Int.Max?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-651727239
@becketqin The problems have been solved, and the current error seems to have nothing to do with our changes .
Looking forward to your reply , thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c607aaed98c957173a95039f7da9df99143b21c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
}, {
"hash" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121",
"triggerID" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7bac4fab3223f42d461d122658e87f541b3b042 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641707884
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641693809
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4086eac47b36d124dd13d8a15261bcc823b89e74 (Wed Jun 10 03:13:08 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-654060300
Thanks for the explanation. Looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #12566:
URL: https://github.com/apache/flink/pull/12566#discussion_r447402523
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/synchronization/FutureCompletingBlockingQueueTest.java
##########
@@ -0,0 +1,22 @@
+package org.apache.flink.connector.base.source.reader.synchronization;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+/**
+ * The unit test for {@link FutureCompletingBlockingQueue}
+ */
+public class FutureCompletingBlockingQueueTest {
+
+ private static final Integer DEFAULT_CAPACITY = 10000;
Review comment:
Should the unit test use a value different from the default value?
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/synchronization/FutureCompletingBlockingQueueTest.java
##########
@@ -0,0 +1,22 @@
+package org.apache.flink.connector.base.source.reader.synchronization;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
Review comment:
Can you add a license header to the file? Also, we usually do not use `*` in the imports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-651554556
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4086eac47b36d124dd13d8a15261bcc823b89e74 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
}, {
"hash" : "c607aaed98c957173a95039f7da9df99143b21c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115",
"triggerID" : "c607aaed98c957173a95039f7da9df99143b21c0",
"triggerType" : "PUSH"
}, {
"hash" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121",
"triggerID" : "c7bac4fab3223f42d461d122658e87f541b3b042",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c607aaed98c957173a95039f7da9df99143b21c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4115)
* c7bac4fab3223f42d461d122658e87f541b3b042 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4121)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-651156382
> @pyscala Thanks for the patch. LGTM. Can we add a unit test for this?
thanks @becketqin for your reply ,i will add a unit test for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118",
"triggerID" : "4086eac47b36d124dd13d8a15261bcc823b89e74",
"triggerType" : "PUSH"
}, {
"hash" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127",
"triggerID" : "887856985088fccc500f51a7ffc00dc8f619aeef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 887856985088fccc500f51a7ffc00dc8f619aeef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3127)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on a change in pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
Posted by GitBox <gi...@apache.org>.
pyscala commented on a change in pull request #12566:
URL: https://github.com/apache/flink/pull/12566#discussion_r447413574
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/synchronization/FutureCompletingBlockingQueueTest.java
##########
@@ -0,0 +1,22 @@
+package org.apache.flink.connector.base.source.reader.synchronization;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+/**
+ * The unit test for {@link FutureCompletingBlockingQueue}
+ */
+public class FutureCompletingBlockingQueueTest {
+
+ private static final Integer DEFAULT_CAPACITY = 10000;
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org