You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "neuyilan (via GitHub)" <gi...@apache.org> on 2023/10/23 03:57:33 UTC
[I] [Bug]The newly cloned tablet will be deleted [doris]
neuyilan opened a new issue, #25744:
URL: https://github.com/apache/doris/issues/25744
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues.
### Version
2.0.2
### What's Wrong?
The reasons are as follows:
Clone process
Assume that node B clones the data on node A. A. B nodes are all BE nodes;
1. Fe initiates the clone task; Generate metadata for a new node's tablet replica in memory; At this point, the tablet state is CLONE.
2. Fe will issue clone tasks to node B;
3. Node B will execute the clone task, and when the execution is completed, the tablet will be added to the local tablet list. Finally, the task will be reported to FE to success.
4. The FE node will modify the status of this tablet to NORMAL;
Reporting process
The problem lies in the fact that BE will regularly (5 seconds) report the status of the tablet on the node it belongs to.
BE will regularly report local tablets to FE. At this time, the report thread on FE will receive the tables reported by this node and compare them with the tablets in FE's memory.
When it is found that there is a tablet in FE but not in BE, the metadata of the tablet on FE will be deleted. Although fe has taken into account the CLONE tablet, that is, if the metadata state of the tablet on fe is not NORMAL, then the logic will not be deleted. That is the comment below.

However, the problem lies here, as modifying the metadata of the tablet is not an atomic operation. That is to say, at this point, BE may have just reported the status to FE, who has changed the status of this tablet to normal (by calling finishCloneTask()).

After deleting this tablet from the FE metadata, the next BE report will report this tablet, but FE no longer has this tablet, but BE will still report it. So we will go to the code below. So this tablet will eventually be deleted.

### What You Expected?
fix the bug
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [I] [Bug]The newly cloned tablet will be deleted [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman closed issue #25744: [Bug]The newly cloned tablet will be deleted
URL: https://github.com/apache/doris/issues/25744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [I] [Bug]The newly cloned tablet will be deleted [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #25744:
URL: https://github.com/apache/doris/issues/25744#issuecomment-3287232235
We're closing this issue because it hasn't been updated in a while.
If you'd like to revive this issue, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org