You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/28 11:26:07 UTC

[GitHub] flink pull request #5596: [FLINK-8804][Build] Integrate flink-shaded 3.0

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5596

    [FLINK-8804][Build] Integrate flink-shaded 3.0

    ## What is the purpose of the change
    
    This PR integrates flink-shaded 3.0 .
    
    ## Brief change log
    
    * pin `flink-shaded-netty` to 2.0
    * bump `flink.shaded.version` to 3.0
    * replace jackson dependency in `flink-sql-client`
    * replace `force-shading` with `flink-shaded-force-shading`
    * remove jackson relocation in flink-dist (now unnecessary as service relocation is fixed)
    * replace jackson dependency in `flink-docs`
    * rebuild REST API docs that were affected by original jackson usage
    
    ## Verifying this change
    
    * jackson dependency replacement are covered by compilation&tests
    
    * verify all maven properties are properly resolved
    * verify jackson services are properly relocated in flink-dist
    * verify REST API docs list the correct field names (conceptually! you don't need to check everything)
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8804

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5596
    
----
commit d941c615351760ce9478ba9a0c288e178b241fb5
Author: zentol <ch...@...>
Date:   2018-02-28T10:42:21Z

    Bump version

commit 7134762c558625e150c0314fb0cb8fc1bd9fdf30
Author: zentol <ch...@...>
Date:   2018-02-28T10:42:32Z

    replace jackson dependency sql-client

commit dc6fb70149d8b18eb9d1bcce6ab1292076dba040
Author: zentol <ch...@...>
Date:   2018-02-28T10:43:04Z

    remove unnecessary jackson relocation in flink-dist

commit a60f622ac58089647c3c340c0699f42f4bc251df
Author: zentol <ch...@...>
Date:   2018-02-28T10:49:22Z

    Replace force-shading

commit 4fcad9ab492b9aadc1d5db7c83138eb4330eab3b
Author: zentol <ch...@...>
Date:   2018-02-28T10:52:00Z

    Replace jackson dependency in flink-docs

commit 816a3b611f6a2f12c56a9eb9d7d9fe3cb8d2f972
Author: zentol <ch...@...>
Date:   2018-02-28T11:03:28Z

    [FLINK-8254]REST][docs] Rebuild REST API docs

----


---

[GitHub] flink issue #5596: [FLINK-8804][Build] Integrate flink-shaded 3.0

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5596
  
    merging


---

[GitHub] flink issue #5596: [FLINK-8804][Build] Integrate flink-shaded 3.0

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5596
  
    I've rebased the PR and minimized it to only contain the jackson changes.


---

[GitHub] flink pull request #5596: [FLINK-8804][Build] Integrate flink-shaded 3.0

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5596


---