You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ashish Singhi (JIRA)" <ji...@apache.org> on 2015/03/15 08:50:38 UTC

[jira] [Commented] (HBASE-13246) Correct the assertion for namespace permissions in tearDown method of TestAccessController

    [ https://issues.apache.org/jira/browse/HBASE-13246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362281#comment-14362281 ] 

Ashish Singhi commented on HBASE-13246:
---------------------------------------

Also found that in *testCoprocessorExec* and *testNamespaceUserGrant* we were granting permission to the {{TEST_TABLE}} namespace and were never revoked. To handle this created separate namespace for the test and deleted at the end of the test.

Please review.

> Correct the assertion for namespace permissions in tearDown method of TestAccessController
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13246
>                 URL: https://issues.apache.org/jira/browse/HBASE-13246
>             Project: HBase
>          Issue Type: Bug
>          Components: security, test
>    Affects Versions: 0.98.11
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>            Priority: Minor
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
>
>         Attachments: HBASE-13246.patch
>
>
> In *TestAcessController#tearDown* we should use {{TEST_TABLE.getNamespaceAsString()}} instead of {{TEST_TABLE.getNameAsString()}} as the assertion is for namespace.
> {code}
> assertEquals(0, AccessControlLists.getNamespacePermissions(conf, TEST_TABLE.getTableName().getNamespaceAsString()).size());
> {code}
> Some credit goes to [~srikanth235] to indirectly point this out [here|https://issues.apache.org/jira/browse/HBASE-13241?focusedCommentId=14361995&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14361995]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)