You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/01 16:19:15 UTC
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request
#887: Define file and position based deletion file in spec
rdblue commented on a change in pull request #887: Define file and position based deletion file in spec
URL: https://github.com/apache/incubator-iceberg/pull/887#discussion_r401741386
##########
File path: site/docs/spec.md
##########
@@ -232,6 +232,7 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo
| **`128 upper_bounds`** | `optional map<129: int, 130: binary>` | Map from column id to upper bound in the column serialized as binary [1]. Each value must be greater than or equal to all values in the column for the file. |
| **`131 key_metadata`** | `optional binary` | Implementation-specific key metadata for encryption |
| **`132 split_offsets`** | `optional list` | Split offsets for the data file. For example, all row group offsets in a Parquet file. Must be sorted ascending. |
+| **`134 file_type`** | `optional int` | Type of the data file. `0`: normal data file that has the same schema as the table's schema. `1`: file and position based deletion file. |
Review comment:
This change should not be in this PR. The purpose of this PR is to define the format of a file and position delete file, not to make additional changes to metadata. Could you remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org