You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/09 19:52:25 UTC

[GitHub] [beam] ibzib commented on a change in pull request #13483: Implemeted ARRAY_AGG fn for Zetasql dialect

ibzib commented on a change in pull request #13483:
URL: https://github.com/apache/beam/pull/13483#discussion_r539600655



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -81,6 +72,12 @@
           x -> createTypeFactory().createSqlType(SqlTypeName.VARCHAR),
           new UdafImpl<>(new StringAgg.StringAggString()));
 
+  public static final SqlOperator ARR_AGG_ARR_FN =
+          createUdafOperator(
+                  "array_agg",
+                  x -> createTypeFactory().createSqlType(SqlTypeName.ARRAY),

Review comment:
       But `ARRAY_AGG` should support all element types, not just `INT64`. https://github.com/google/zetasql/blob/master/docs/aggregate_functions.md#array_agg




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org