You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/22 05:31:13 UTC
[GitHub] [pulsar-client-go] freeznet opened a new pull request #548: regenerate the certs & tokens to work with Java 11
freeznet opened a new pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548
### Motivation
Pulsar 2.8.0 moves to JDK 11 and no longer support SHA1 signature algorithm. ref: "[JEP 288: Disable SHA-1 Certificates](https://openjdk.java.net/jeps/288)".
To make pulsar-client-go CI works with the latest pulsar release, this PR uses sha256 to generate certs, according to [Transport Encryption using TLS](http://pulsar.apache.org/docs/en/next/security-tls-transport/) and [Authentication using TLS](http://pulsar.apache.org/docs/en/next/security-tls-authentication/)
this PR is a rework for #544
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on a change in pull request #548: regenerate the certs to work with Pulsar 2.8.0 and Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on a change in pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#discussion_r656110752
##########
File path: pulsar/internal/http_client.go
##########
@@ -52,7 +52,7 @@ func (c *httpClient) Close() {
}
type HTTPClient interface {
- Get(endpoint string, obj interface{}) error
+ Get(endpoint string, obj interface{}, params map[string]string) error
Review comment:
> Is this change related to the certificate updates
it is related to Pulsar 2.8.0, seems the `GetPartitionedTopicMetadata` with http lookup service has to pass `checkAllowAutoCreation=true` as params to get the partition num of the non-existed topic. So once we run CI with Pulsar 2.8.0, the tests will fail. [related with [#10601](https://github.com/apache/pulsar/pull/10601)]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865661689
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat merged pull request #548: regenerate the certs to work with Pulsar 2.8.0 and Java 11
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865840281
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on a change in pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on a change in pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#discussion_r656111453
##########
File path: pulsar/internal/lookup_service.go
##########
@@ -325,9 +325,11 @@ func (h *httpLookupService) GetPartitionedTopicMetadata(topic string) (*Partitio
path := fmt.Sprintf(format, GetTopicRestPath(topicName))
+ h.log.Infof("Fetch topic{%s} partitioned metadata %s", topic, path)
Review comment:
I have removed this line since I was trying to debug the reason why the tests are failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865622358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865622358
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#discussion_r656081919
##########
File path: pulsar/internal/lookup_service.go
##########
@@ -325,9 +325,11 @@ func (h *httpLookupService) GetPartitionedTopicMetadata(topic string) (*Partitio
path := fmt.Sprintf(format, GetTopicRestPath(topicName))
+ h.log.Infof("Fetch topic{%s} partitioned metadata %s", topic, path)
Review comment:
This we should maybe leave as debug level
##########
File path: pulsar/internal/http_client.go
##########
@@ -52,7 +52,7 @@ func (c *httpClient) Close() {
}
type HTTPClient interface {
- Get(endpoint string, obj interface{}) error
+ Get(endpoint string, obj interface{}, params map[string]string) error
Review comment:
Is this change related to the certificate updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on a change in pull request #548: regenerate the certs & tokens to work with Java 11
Posted by GitBox <gi...@apache.org>.
freeznet commented on a change in pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#discussion_r656110752
##########
File path: pulsar/internal/http_client.go
##########
@@ -52,7 +52,7 @@ func (c *httpClient) Close() {
}
type HTTPClient interface {
- Get(endpoint string, obj interface{}) error
+ Get(endpoint string, obj interface{}, params map[string]string) error
Review comment:
> Is this change related to the certificate updates
it is related to Pulsar 2.8.0, seems the `GetPartitionedTopicMetadata` with http lookup service has to pass `checkAllowAutoCreation=true` as params to get the partition num of the non-existed topic. So once we run CI with Pulsar 2.8.0, the tests will fail. [related with https://github.com/apache/pulsar/pull/10601]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org