[jira] [Resolved] (ZEST-107) Entity SPI: JSONEntityState cloning logic is flawed

["Paul Merlin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZEST-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Merlin resolved ZEST-107.
------------------------------
    Resolution: Fixed

Fixed, see 5d3d759.

Tests passed locally with services running.
Tests passed on b.a.o.

Thanks Tibor!

> Entity SPI: JSONEntityState cloning logic is flawed
> ---------------------------------------------------
>
>                 Key: ZEST-107
>                 URL: https://issues.apache.org/jira/browse/ZEST-107
>             Project: Zest
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Tibor Mlynarik
>            Assignee: Paul Merlin
>             Fix For: 2.1
>
>
> The cloneStateIfGlobalStateLoaded() method of JSONEntityState is called before any change is made to the entity state.
> This method starts with the following check:
> if( isStateNotCloned() )
> {
>     return;
> }
> // Do the clone
> And the (private) isStateNotCloned() method returns:
> status == EntityStatus.LOADED
> IOW, the code says that it will clone state if status is loaded, but it does the opposite!
> See discussion: http://s.apache.org/1QI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)