You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/04/10 06:53:25 UTC
[GitHub] [openwhisk-wskdebug] alexkli opened a new pull request #39: make
ngrok an optional dependency
alexkli opened a new pull request #39: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/pull/39
Fixes #22.
No unit test yet. Might add one tomorrow using a docker container doing "fresh" npm installs...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] dgrove-oss commented on a change in pull
request #39: make ngrok an optional dependency
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #39: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/pull/39#discussion_r406897257
##########
File path: README.md
##########
@@ -474,7 +472,7 @@ run this instead:
sudo npm install -g @openwhisk/wskdebug --unsafe-perm=true --allow-root
```
-The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/inconshreveable/ngrok/issues/429).
+The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/bubenshchykov/ngrok/issues/87).
Review comment:
right. guess it makes sense to leave comment in for a little while (or until the next release). without the history, it just reads a little oddly since it is telling people about problems with an install mode that isn't mentioned anywhere else in the doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] dgrove-oss commented on a change in pull
request #39: make ngrok an optional dependency
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #39: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/pull/39#discussion_r406709320
##########
File path: README.md
##########
@@ -474,7 +472,7 @@ run this instead:
sudo npm install -g @openwhisk/wskdebug --unsafe-perm=true --allow-root
```
-The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/inconshreveable/ngrok/issues/429).
+The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/bubenshchykov/ngrok/issues/87).
Review comment:
Wondering if the `sudo npm install...` command just above this block should be changed to just installing ngrok instead of openwhisk/debug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli commented on a change in pull request
#39: make ngrok an optional dependency
Posted by GitBox <gi...@apache.org>.
alexkli commented on a change in pull request #39: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/pull/39#discussion_r406808038
##########
File path: README.md
##########
@@ -474,7 +472,7 @@ run this instead:
sudo npm install -g @openwhisk/wskdebug --unsafe-perm=true --allow-root
```
-The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/inconshreveable/ngrok/issues/429).
+The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/bubenshchykov/ngrok/issues/87).
Review comment:
This is not the normal install command. This is the troubleshooting section which I kept in for folks still having an older version...
This PR was all about making the normal command easier from the very unusual
```
npm install -g @openwhisk/wskdebug --unsafe-perm=true
```
to the usual
```
npm install -g @openwhisk/wskdebug
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli merged pull request #39: make ngrok an
optional dependency
Posted by GitBox <gi...@apache.org>.
alexkli merged pull request #39: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/pull/39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli commented on a change in pull request
#39: make ngrok an optional dependency
Posted by GitBox <gi...@apache.org>.
alexkli commented on a change in pull request #39: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/pull/39#discussion_r406960749
##########
File path: README.md
##########
@@ -474,7 +472,7 @@ run this instead:
sudo npm install -g @openwhisk/wskdebug --unsafe-perm=true --allow-root
```
-The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/inconshreveable/ngrok/issues/429).
+The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/bubenshchykov/ngrok/issues/87).
Review comment:
Yes, will remove after the next release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services