You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 09:31:19 UTC

[GitHub] [flink] GJL opened a new pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

GJL opened a new pull request #12019:
URL: https://github.com/apache/flink/pull/12019


   ## What is the purpose of the change
   
   *This adds details on how to run Jepsen tests.*
   
   ## Brief change log
   
     - *See commits*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625150097


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d91dd65362a1932a6663a437e6a30266dea8319 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625150097


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737",
       "triggerID" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1270",
       "triggerID" : "e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1270) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625150097


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737",
       "triggerID" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d91dd65362a1932a6663a437e6a30266dea8319 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737) 
   * e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625150097


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737",
       "triggerID" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1270",
       "triggerID" : "e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d91dd65362a1932a6663a437e6a30266dea8319 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737) 
   * e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1270) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GJL closed pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

GJL closed pull request #12019:
URL: https://github.com/apache/flink/pull/12019


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625150097


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737",
       "triggerID" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d91dd65362a1932a6663a437e6a30266dea8319 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GJL commented on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

GJL commented on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-629839131


   Merged. Thanks for reviewing. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625142819

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 1d91dd65362a1932a6663a437e6a30266dea8319 (Thu May 07 09:34:29 UTC 2020)

**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625142819

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit e6d3120e9b2f7c5149b7b2d2928c2975e1e49ef8 (Fri Oct 16 10:35:07 UTC 2020)

**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12019:
URL: https://github.com/apache/flink/pull/12019#issuecomment-625150097


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737",
       "triggerID" : "1d91dd65362a1932a6663a437e6a30266dea8319",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d91dd65362a1932a6663a437e6a30266dea8319 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=737) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GJL commented on a change in pull request #12019: [FLINK-17522][tests] Add details on how to run Jepsen tests

Posted by GitBox <gi...@apache.org>.

GJL commented on a change in pull request #12019:
URL: https://github.com/apache/flink/pull/12019#discussion_r425003486



##########
File path: flink-jepsen/README.md
##########
@@ -27,18 +27,55 @@ To simplify development, we have prepared Dockerfiles and a [Docker Compose](htt
 so that you can run the tests locally in containers (see Section [Docker](#usage-docker)).
 
 ### Running Tests
-This project does not comprise of only a single test that can be run but rather a parameterizable
-test template. This allows the user to specify the cluster manager that Flink should be on, the
-location of the high availability storage directory, the jobs to be submitted, etc.
-The script under `docker/run-tests.sh` shows examples on how to specify and run tests.
-By default, the example tests run the `DataStreamAllroundTestProgram`, which is located under
-`flink-end-to-end-tests/flink-datastream-allround-test` of the Flink project root.
-Before running the tests, you have to build the job first, and copy the resulting jar
-(`DataStreamAllroundTestProgram.jar`) to the `./bin` directory of this project's root.
-Also included in the examples is a more complicated scenario with two jobs that share a Kafka
-topic. See the `run-tests.sh` script for details on how to enable and run this test.
+Tests are started from the control node. Therefore, the contents of this directory

Review comment:
       Added additional paragraph.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org