You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/02/03 02:51:36 UTC

Review Request 43129: GEODE-898: Fixing a race in SerialWANStatsDUnitTest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43129/
-----------------------------------------------------------

Review request for geode, Barry Oglesby and xiaojian zhou.


Repository: geode


Description
-------

testSerialPropegationConflation was a pausing a sender, but not waiting
for it to pause. It's possible some events could be sent while the pause
was in progress.


Diffs
-----

  gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANStatsDUnitTest.java a142f82fbee1ffd2dd33de7c38cb07a5c618f776 

Diff: https://reviews.apache.org/r/43129/diff/


Testing
-------


Thanks,

Dan Smith


Re: Review Request 43129: GEODE-898: Fixing a race in SerialWANStatsDUnitTest

Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43129/#review117577
-----------------------------------------------------------


Ship it!




Ship It!

- xiaojian zhou


On Feb. 3, 2016, 1:51 a.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43129/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 1:51 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> testSerialPropegationConflation was a pausing a sender, but not waiting
> for it to pause. It's possible some events could be sent while the pause
> was in progress.
> 
> 
> Diffs
> -----
> 
>   gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANStatsDUnitTest.java a142f82fbee1ffd2dd33de7c38cb07a5c618f776 
> 
> Diff: https://reviews.apache.org/r/43129/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>