[GitHub] [superset] michael-s-molina commented on a diff in pull request #25274: chore(sqllab): Migrate tests to typescript

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on code in PR #25274:
URL: https://github.com/apache/superset/pull/25274#discussion_r1323468056


##########
superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.tsx:
##########
@@ -17,12 +17,9 @@
  * under the License.
  */
 import React from 'react';
-import SyntaxHighlighter from 'react-syntax-highlighter';
-import { mount, shallow } from 'enzyme';
 
 import HighlightedSql from 'src/SqlLab/components/HighlightedSql';
-import ModalTrigger from 'src/components/ModalTrigger';
-import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { fireEvent, render } from 'spec/helpers/testing-library';

Review Comment:
   Thank you @justinpark for the improvements! We generally avoid `describe` and `it` in RTL tests. Could you also update those?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org