[GitHub] [doris] zhannngchen commented on a diff in pull request #21746: [feature](partial update) add failure tolerance for strict mode partial update stream load

["zhannngchen (via GitHub)" <gi...@apache.org>]

zhannngchen commented on code in PR #21746:
URL: https://github.com/apache/doris/pull/21746#discussion_r1261184268


##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -408,6 +417,25 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*
     auto mutable_full_columns = full_block.mutate_columns();
     RETURN_IF_ERROR(fill_missing_columns(mutable_full_columns, use_default_or_null_flag,
                                          has_default_or_nullable));
+
+    if (_tablet_schema->is_strict_mode() && num_rows_filtered > 0) {
+        // size_t dest_size = full_block.columns();
+        // full_block.insert(vectorized::ColumnWithTypeAndName(
+        //         std::move(filter_column), std::make_shared<vectorized::DataTypeUInt8>(),
+        //         "filter column"));
+        // RETURN_IF_ERROR(vectorized::Block::filter_block(&full_block, dest_size, dest_size));
+        auto& delete_column_data =
+                assert_cast<vectorized::ColumnInt8*>(
+                        full_block.get_by_name(DELETE_SIGN).column->assume_mutable().get())

Review Comment:
   use delete bitmap instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org