You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mcmellawatt (GitHub)" <gi...@apache.org> on 2019/01/19 20:00:53 UTC
[GitHub] [geode] mcmellawatt opened pull request #3102: GEODE-6304:
Refactor memory monitor to properly reset tolerance counter
The tolerance counter was not properly being reset between
non-consecutive EVICTION and CRITICAL events. To fix this and make it
more understandable, the threshold logic was combined with the logic to
compute the next state in the MemoryThreshold state machine. The
counter is now reset between non-consecutive EVICTION and CRITICAL
events.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3102: GEODE-6304:
Refactor memory monitor to properly reset tolerance counter
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
I think it might be easier to read if you throw this in a for loop.
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt closed pull request #3102: GEODE-6304:
Refactor memory monitor to properly reset tolerance counter
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3102: GEODE-6304:
Refactor memory monitor to properly reset tolerance counter
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Same with the other tests in this file
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #3102:
GEODE-6304: Refactor memory monitor to properly reset tolerance counter
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
I'll look into this...these tests were here prior to this PR - I just changed the value of the tolerance, but this is as good as any time to refactor these to be cleaner. Because I wrapped the code in a `try` `finally` block, this shows up in GitHub as a big delete and add, which is somewhat misleading...
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3102: GEODE-6304:
Refactor memory monitor to properly reset tolerance counter
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
It looks like there is a bit of duplication in this block and around line 2555. Is there an opportunity to refactor?
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jhuynh1 commented on pull request #3102: GEODE-6304:
Refactor memory monitor to properly reset tolerance counter
Posted by "jhuynh1 (GitHub)" <gi...@apache.org>.
There is a default(s) level change here, should there be a discuss on the user/dev list?
[ Full content available at: https://github.com/apache/geode/pull/3102 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org