[GitHub] [lucene] janhoy commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

[GitBox <gi...@apache.org>]

janhoy commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942078856


   I am now able to run the smoke tester on the freshly built artifacts, and it validates checksums, unpacks, runs demo indexer etc.
   
   Currently it is complaining about the src package not having the NOTICE file on top level, but that will be fixed by consolidating various text files across root and lucene/ folders. I believe it makes sense to have all these on top-level.
   
   I also tested the built-in signing with
   ```bash
   gw assembleRelease -Dversion.release=9.0.0 -Psign -Psigning.keyId=0D8D0B93 -Psigning.password=$GPGPASS -Pvalidation.git.failOnModified=false -Psigning.secretKeyRingFile=$HOME/.gnupg/secring.gpg
   ```
   
   I just put my passphrase in a shell env.var. Is there a default ENV.VAR I could have used in place of this?
   I had to point to my gpg secring. Do we always have to provide that, or will the build try to resolve common locations? If moving from gpg to built-in, the `buildAndPushRelease.py` script needs to relate to this secring, and either ask user where it is or have a list of common locations??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org