You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/04/03 12:09:47 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18310: [Optimization](functions)Optimize function call for const columns.
github-actions[bot] commented on code in PR #18310:
URL: https://github.com/apache/doris/pull/18310#discussion_r1155874662
##########
be/src/vec/columns/column_array.h:
##########
@@ -27,6 +27,14 @@
#include "vec/common/assert_cast.h"
#include "vec/core/types.h"
+//TODO: use marcos below to decouple array function calls
+#define ALL_COLUMNS_NUMBER \
+ ColumnUInt8, ColumnInt8, ColumnInt16, ColumnInt32, ColumnInt64, ColumnInt128, ColumnFloat32, \
+ ColumnFloat64, ColumnDecimal32, ColumnDecimal64, ColumnDecimal128I, ColumnDecimal128
+#define ALL_COLUMNS_TIME ColumnDate, ColumnDateTime, ColumnDateV2, ColumnDateTimeV2
+#define ALL_COLUMNS_NUMERIC ALL_COLUMNS_NUMBER, ALL_COLUMNS_TIME
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define ALL_COLUMNS_NUMERIC ALL_COLUMNS_NUMBER, ALL_COLUMNS_TIME
^
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -27,6 +27,14 @@
#include "vec/common/assert_cast.h"
#include "vec/core/types.h"
+//TODO: use marcos below to decouple array function calls
+#define ALL_COLUMNS_NUMBER \
+ ColumnUInt8, ColumnInt8, ColumnInt16, ColumnInt32, ColumnInt64, ColumnInt128, ColumnFloat32, \
+ ColumnFloat64, ColumnDecimal32, ColumnDecimal64, ColumnDecimal128I, ColumnDecimal128
+#define ALL_COLUMNS_TIME ColumnDate, ColumnDateTime, ColumnDateV2, ColumnDateTimeV2
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define ALL_COLUMNS_TIME ColumnDate, ColumnDateTime, ColumnDateV2, ColumnDateTimeV2
^
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -27,6 +27,14 @@
#include "vec/common/assert_cast.h"
#include "vec/core/types.h"
+//TODO: use marcos below to decouple array function calls
+#define ALL_COLUMNS_NUMBER \
+ ColumnUInt8, ColumnInt8, ColumnInt16, ColumnInt32, ColumnInt64, ColumnInt128, ColumnFloat32, \
+ ColumnFloat64, ColumnDecimal32, ColumnDecimal64, ColumnDecimal128I, ColumnDecimal128
+#define ALL_COLUMNS_TIME ColumnDate, ColumnDateTime, ColumnDateV2, ColumnDateTimeV2
+#define ALL_COLUMNS_NUMERIC ALL_COLUMNS_NUMBER, ALL_COLUMNS_TIME
+#define ALL_COLUMNS_SIMPLE ALL_COLUMNS_NUMERIC, ColumnString
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define ALL_COLUMNS_SIMPLE ALL_COLUMNS_NUMERIC, ColumnString
^
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -27,6 +27,14 @@
#include "vec/common/assert_cast.h"
#include "vec/core/types.h"
+//TODO: use marcos below to decouple array function calls
+#define ALL_COLUMNS_NUMBER \
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define ALL_COLUMNS_NUMBER \
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org