You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/11 07:25:39 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
GabrielBrascher opened a new pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
## Description
<!--- Describe your changes in detail -->
This PR sets properly Broadcast URI to `vxlan://vxlan_id` when the physical network is of VXLAN.
Fixes: #3040
Description of issue #3040:
> Advanced Network zone with VXLAN is created. When creating a guest network and setting the VNI this is set for the network:
> broadcast_uri: vlan://1000
> isolation_uri: vlan://1000
>
> STEPS TO REPRODUCE
>
> Create a Advanced Zone with VXLAN
> Create a guest network
> See that broadcast is set to vlan and not vxlan
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
**Prior to the fix:**
**After the fix:**
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. Create a Advanced Zone with VXLAN
2. Create a guest network
3. See that broadcast uri is set to vxlan
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#discussion_r485970156
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2475,6 +2475,21 @@ public Network doInTransaction(final TransactionStatus status) {
return network;
}
+ /**
+ * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
+ * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
+ */
+ protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
+ if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
Review comment:
@GabrielBrascher Should we check if `pNtwk` is null? This could potentially cause a NPE; and the getIsolationMethods() is also a valid list with at least one item
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-672780469
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673936617
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696133968
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-664244519
Packaging result: ✖centos7 ✔debian. JID-1604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696575644
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-652376752
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-679966568
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-672733284
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#discussion_r493210363
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2475,6 +2475,21 @@ public Network doInTransaction(final TransactionStatus status) {
return network;
}
+ /**
+ * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
+ * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
+ */
+ protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
+ if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
Review comment:
@GabrielBrascher please add the null validation, thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-671483668
@rhtyd I just tested on master and the problem is still there.
I also gave a quick look at the codebase and could not see any recent commit addressing this. I am assuming that current master has all 4.14 committs forward-merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673407796
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696575644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-664216443
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-687650476
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696126984
@rhtyd update code with the null validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-672766943
Packaging result: ✔centos7 ✔debian. JID-1726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-664246533
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-671777564
kick
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-671483668
@rhtyd I just tested on master and the problem is still there.
I also gave a quick look at the codebase and could not see any recent commit addressing this. I am assuming that current master has all 4.14 committs forwarded merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673963792
Packaging result: ✔centos7 ✔debian. JID-1751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#discussion_r486084710
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2475,6 +2475,21 @@ public Network doInTransaction(final TransactionStatus status) {
return network;
}
+ /**
+ * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
+ * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
+ */
+ protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
+ if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
Review comment:
Actually, NetworkOrchestrator.java#L2397 is not exactly a null validation. I will add a null verification @rhtyd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-679965960
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#discussion_r448341456
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2475,6 +2475,21 @@ public Network doInTransaction(final TransactionStatus status) {
return network;
}
+ /**
+ * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
+ * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
+ */
+ protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
+ if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
Review comment:
I got wondering if there could be more than one isolation method on a network. Considering that this is a List of isolation methods. I assume that to get into a VLAN conditional (the ones that this method is called) there will be only one isolation method, either VLAN or VXLAN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-679929046
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696133968
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-688396807
<b>Trillian test result (tid-2680)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37095 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4190-t2680-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 305.66 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 204.71 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 323.17 | test_privategw_acl.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 281.06 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-671777355
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-672780179
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-664279329
Packaging result: ✔centos7 ✔debian. JID-1608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696575226
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673250879
<b>Trillian test result (tid-2383)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64786 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4190-t2383-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 225.19 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 218.13 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 308.83 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.40 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.40 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.47 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.43 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.67 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.29 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.21 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.18 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.57 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1513.86 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-683247042
<b>Trillian test result (tid-2598)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 73635 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4190-t2598-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 54 look OK, 23 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 495.14 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 609.05 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 413.72 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 465.99 | test_internal_lb.py
test_02_vpc_privategw_static_routes | `Failure` | 302.73 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 340.93 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 433.66 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.34 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.11 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.09 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.08 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.09 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.10 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.08 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.10 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.08 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.08 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.08 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.46 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.50 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.57 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.52 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.19 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.29 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.16 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.28 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.06 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.18 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.68 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1515.69 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-683264459
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-698124308
Will merge and then need to kick tests on 4.14 and master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-698124308
Will merge and then need to kick tests on 4.14 and master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-693293890
@rhtyd I am a bit offline this week due to vacation. I Will get back at 21st September. As soon as I get back I will add the null validation and update this PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-679959631
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673407215
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-652376326
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-687650319
(centos8 pkg failure is expected as it's not supported on 4.13/4.14 and before)
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696134643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-672733678
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696126984
@rhtyd update code with the null validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696126984
@rhtyd updated the code with the null validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696881519
<b>Trillian test result (tid-2828)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32434 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4190-t2828-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 213.08 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 230.40 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 309.05 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-682424032
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696134643
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-693237921
@GabrielBrascher can you advise when this is ready for merging, thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-664215855
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696575226
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-684790755
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673936259
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-684743463
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-682423445
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-652385984
Packaging result: ✔centos7 ✔debian. JID-1498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696149400
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-673250879
<b>Trillian test result (tid-2383)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64786 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4190-t2383-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 225.19 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 218.13 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 308.83 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.40 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.40 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.47 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.43 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.67 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.29 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.21 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.18 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.57 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1513.86 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669077357
Packaging result: ✖centos7 ✔debian. JID-1657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669062103
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-683264530
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-684744176
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-679929262
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#discussion_r485981641
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2475,6 +2475,21 @@ public Network doInTransaction(final TransactionStatus status) {
return network;
}
+ /**
+ * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
+ * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
+ */
+ protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
+ if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
Review comment:
@rhtyd thanks for the review :-)
Answering your question: I did not add null verification on the respective parameter due to the fact that both methods that call this one already validate the private network
1. the physical network `pNtwk` is validated at [NetworkOrchestrator.java#L2196](https://github.com/apache/cloudstack/blob/2c3a41c7a63dfd1dd271578eacec26442ee039f9/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L2196);
2. the other method that calls `encodeVlanIdIntoBroadcastUri` also validates the private network at this line [NetworkOrchestrator.java#L2397](https://github.com/apache/cloudstack/blob/2c3a41c7a63dfd1dd271578eacec26442ee039f9/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L2397).
However, considering that this method could be reused, I have no problem in adding null validations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-664247085
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669061792
@GabrielBrascher did you try against 4.14, somehow I remember this was fixed recently? Thanks.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669081062
@rhtyd I will take a look at 4.14 and 4.15 then. If it has already been fixed I will close this one. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-696126984
@rhtyd updated the code with the null validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org