You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/21 12:12:05 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
lidavidm opened a new pull request, #13406:
URL: https://github.com/apache/arrow/pull/13406
Clarify the flags required up-front. Note that they're required for JDK9+, not JDK17+. Update the note about which versions are tested in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13406:
URL: https://github.com/apache/arrow/pull/13406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13406:
URL: https://github.com/apache/arrow/pull/13406#discussion_r914978992
##########
docs/source/java/install.rst:
##########
@@ -28,7 +28,13 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18, but only JDK 11 is tested in CI.
+Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18.
+Currently, JDK 8, 11, 17, and 18 are tested in CI.
+
+When using Java 9 or later, some JDK internals must be exposed by
Review Comment:
That is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13406:
URL: https://github.com/apache/arrow/pull/13406#discussion_r914993716
##########
docs/source/java/install.rst:
##########
@@ -28,7 +28,13 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18, but only JDK 11 is tested in CI.
+Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18.
+Currently, JDK 8, 11, 17, and 18 are tested in CI.
+
+When using Java 9 or later, some JDK internals must be exposed by
Review Comment:
Thanks. Let's keep it as is then, there's no need to mention a deprecated flag when the more specific one will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13406:
URL: https://github.com/apache/arrow/pull/13406#discussion_r914753587
##########
docs/source/java/install.rst:
##########
@@ -28,7 +28,13 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18, but only JDK 11 is tested in CI.
+Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18.
+Currently, JDK 8, 11, 17, and 18 are tested in CI.
+
+When using Java 9 or later, some JDK internals must be exposed by
Review Comment:
So `--illegal-access` no longer works in Java 17. But the `--add-opens` flag works in all these versions, so there's no concern, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13406:
URL: https://github.com/apache/arrow/pull/13406#issuecomment-1161665356
CC @davisusanibar please take a look if you have a chance, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #13406: MINOR: [Docs][Java] Clarify Java CI and JDK9 flags
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13406:
URL: https://github.com/apache/arrow/pull/13406#discussion_r914068838
##########
docs/source/java/install.rst:
##########
@@ -28,7 +28,13 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18, but only JDK 11 is tested in CI.
+Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18.
+Currently, JDK 8, 11, 17, and 18 are tested in CI.
+
+When using Java 9 or later, some JDK internals must be exposed by
Review Comment:
I agree with this note to be more generic.
But only to maintain as a documentation: The main problem was with JDK17 by `it will no longer be possible to relax the strong encapsulation of internal elements using a single command-line option, as it was possible in JDK 9 through JDK 16.` and the jvm argument `--add-opens=java.base/java.nio=ALL-UNNAMED` will need to be used to handle the strong encapsulation violation.
- https://docs.oracle.com/en/java/javase/17/migrate/significant-changes-jdk-release.html#GUID-339B2415-8BA8-438C-93AF-F9C746F7CE45
- https://openjdk.org/jeps/403
- https://bugs.openjdk.org/browse/JDK-8263547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org