You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/03 07:40:27 UTC
[GitHub] [pulsar] wangjialing218 commented on a change in pull request #8806: fix force delete namespace did not delete all topics of the namespace
wangjialing218 commented on a change in pull request #8806:
URL: https://github.com/apache/pulsar/pull/8806#discussion_r534826096
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -411,9 +411,12 @@ protected void internalDeleteNamespaceForcefully(AsyncResponse asyncResponse, bo
// firstly remove all topics including system topics
if (!topics.isEmpty()) {
for (String topic : topics) {
- pulsar().getBrokerService().getTopicIfExists(topic).whenComplete((topicOptional, ex) -> {
- topicOptional.ifPresent(tp -> futures.add(tp.deleteForcefully()));
- });
+ try {
Review comment:
Added test for force delete namespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org