You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/29 10:56:27 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
tooptoop4 opened a new pull request #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948
…rigger_dag
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-569497285
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=h1) Report
> Merging [#6948](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6948 +/- ##
==========================================
- Coverage 84.7% 84.41% -0.29%
==========================================
Files 680 680
Lines 38556 38560 +4
==========================================
- Hits 32659 32552 -107
- Misses 5897 6008 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==) | `95.91% <75%> (-1.86%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=footer). Last update [7d97d16...b056762](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-569497285
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=h1) Report
> Merging [#6948](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6948 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 680 679 -1
Lines 38556 38540 -16
==========================================
- Hits 32659 32592 -67
- Misses 5897 5948 +51
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==) | `97.95% <100%> (+0.18%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `86.2% <0%> (-0.51%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=footer). Last update [7d97d16...2fbbaf7](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-569499677
Nice one. How about adding a test for that @tooptoop4 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-571354709
OK. I see it now. The confusion was due to one of the links in the PR did not have JIRA_ID and opened another issue. then I copied the other link :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
tooptoop4 edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-570088598
@potiuk tests added, pls merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-569497285
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=h1) Report
> Merging [#6948](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6948 +/- ##
==========================================
- Coverage 84.7% 84.41% -0.29%
==========================================
Files 680 680
Lines 38556 38560 +4
==========================================
- Hits 32659 32552 -107
- Misses 5897 6008 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==) | `95.91% <75%> (-1.86%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6948/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=footer). Last update [7d97d16...b056762](https://codecov.io/gh/apache/airflow/pull/6948?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-571328938
@tooptoop4 - are you sure that the issue id was correct in this one ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-571329119
This looks like completely different issue: https://issues.apache.org/jira/browse/AIRFLOW-4428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-571314570
@potiuk gentle ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
tooptoop4 edited a comment on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-571331086
@potiuk it is right jira, comments in jira explain the reasoning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-571331086
@potiuk it is right jira, comments in lira explain the reasoning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6948: [AIRFLOW-4428] error if exec_date before default_args.start_date in t…
URL: https://github.com/apache/airflow/pull/6948#issuecomment-570088598
@potiuk tests added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services