[GitHub] [cloudstack] davidjumani commented on a change in pull request #4412: Validating type parameter and including all types

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #4412:
URL: https://github.com/apache/cloudstack/pull/4412#discussion_r507595743



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
##########
@@ -101,7 +102,13 @@ public Long getZoneId() {
     }
 
     public String getGuestIpType() {
-        return guestIpType;
+        if (!Strings.isNullOrEmpty(guestIpType)) {
+            if (guestIpType.equalsIgnoreCase("all")) {
+                return null;
+            }
+            return Network.GuestType.fromValue(guestIpType).toString();
+        }
+        return null;

Review comment:
       that's right!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org