[GitHub] [beam] robertwb commented on a diff in pull request #22999: Allow expansion service to choose pickler.

[GitBox <gi...@apache.org>]

robertwb commented on code in PR #22999:
URL: https://github.com/apache/beam/pull/22999#discussion_r964214805


##########
sdks/python/apache_beam/internal/pickler.py:
##########
@@ -68,10 +68,12 @@ def load_session(file_path):
 def set_library(selected_library=DEFAULT_PICKLE_LIB):
   """ Sets pickle library that will be used. """
   global desired_pickle_lib
-  if selected_library == USE_DILL and desired_pickle_lib != dill_pickler:
+  if (selected_library == USE_DILL) != (desired_pickle_lib == dill_pickler):

Review Comment:
   If the new value of (pickler is dill) is different than the old value, we have to set (or unset) the hooks. Added a comment to clarify.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org