You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by andralungu <gi...@git.apache.org> on 2015/05/08 23:06:47 UTC

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

GitHub user andralungu opened a pull request:

    https://github.com/apache/flink/pull/663

    [FLINK-1976][gelly] Added ForwardedFields Annotations

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andralungu/flink fwdFields

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #663
    
----
commit 3866e61ae16f132f433ddc85eb523748637d171d
Author: andralungu <lu...@gmail.com>
Date:   2015-05-08T21:05:31Z

    [FLINK-1976][gelly] Added ForwardedFields Annotations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-100370285
  
    @andralungu , please add more description about the PR to help people review and understand why this PR is made.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-101972007
  
    Guys, 
    
    Maybe it makes sense to merge this :)
    It's been here for a while. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-100543436
  
    The annotations look good to me. 
    I think one more annotation could be added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-100372745
  
    Sure @hsaputra , 
    
    I thought the JIRA issue was descriptive enough. We were missing ForwardedFields* annotations for the majority of Gelly classes in Graph.java especially. 
    This annotation, as I am sure you know, helps the optimizer generate more efficient execution plans. 
    
    Placing it in front of the classes is optional, but I believe it helps. 
    @vasia and @fhueske also agreed. In fact this was Fabian's observation when surfing the Gelly code. Thanks again, Fabian! :) 
    
    I hope things are clearer now, @hsaputra. Let me know if you have further questions :)   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/663#discussion_r29996107
  
    --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
    @@ -1329,6 +1355,7 @@ public void join(Tuple3<K, K, Edge<K, EV>> keysWithEdge, Vertex<K, VV> neighbor,
     		}
     	}
     
    +	@ForwardedFieldsFirst("f0; f2->f1")
    --- End diff --
    
    Add `@ForwardedFieldsSecond("*->f2")`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-100544083
  
    Indeed I was missing that annotation. Nice catch!
    PR updated :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-100516246
  
    Thx @andralungu, really appreciate it.
    Usually JIRA issue describes what is the problem or task to do, and pull request description should tell how and why certain changes were made in the patch to help reviewers understand the context and your line of thoughts. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/663#issuecomment-102302338
  
    Thanks for pinging. 
    I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---