You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/28 21:04:20 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
nsivabalan opened a new pull request #5158:
URL: https://github.com/apache/hudi/pull/5158
## What is the purpose of the pull request
Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
## Brief change log
- Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli. Adding an argument to savepoint_rollback
## Verify this pull request
- Verified the fix locally with hudi-cli
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
codope merged pull request #5158:
URL: https://github.com/apache/hudi/pull/5158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#discussion_r837780774
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SavepointsCommand.java
##########
@@ -93,6 +93,8 @@ public String rollbackToSavepoint(
@CliOption(key = {"savepoint"}, help = "Savepoint to rollback") final String instantTime,
@CliOption(key = {"sparkProperties"}, help = "Spark Properties File Path") final String sparkPropertiesPath,
@CliOption(key = "sparkMaster", unspecifiedDefaultValue = "", help = "Spark Master") String master,
+ @CliOption(key = {"LazyFailedWritesCleanPolicy"}, help = "True if FailedWriteCleanPolicy is lazy",
Review comment:
nit: shall we follow the convention of camel-case starting with lowercase? `lazyFailedWritesCleanPolicy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#discussion_r839007158
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SavepointsCommand.java
##########
@@ -93,6 +93,8 @@ public String rollbackToSavepoint(
@CliOption(key = {"savepoint"}, help = "Savepoint to rollback") final String instantTime,
@CliOption(key = {"sparkProperties"}, help = "Spark Properties File Path") final String sparkPropertiesPath,
@CliOption(key = "sparkMaster", unspecifiedDefaultValue = "", help = "Spark Master") String master,
+ @CliOption(key = {"LazyFailedWritesCleanPolicy"}, help = "True if FailedWriteCleanPolicy is lazy",
Review comment:
my bad. will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1081209282
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1084008529
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
}, {
"hash" : "35481045e9f77ced3079a717ae53791986de2a94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35481045e9f77ced3079a717ae53791986de2a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
* 35481045e9f77ced3079a717ae53791986de2a94 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1081154414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1084010103
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
}, {
"hash" : "35481045e9f77ced3079a717ae53791986de2a94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7606",
"triggerID" : "35481045e9f77ced3079a717ae53791986de2a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
* 35481045e9f77ced3079a717ae53791986de2a94 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7606)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1084177622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
}, {
"hash" : "35481045e9f77ced3079a717ae53791986de2a94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7606",
"triggerID" : "35481045e9f77ced3079a717ae53791986de2a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35481045e9f77ced3079a717ae53791986de2a94 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7606)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1081154414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1081209282
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1081147514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1081147514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1084008529
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
}, {
"hash" : "35481045e9f77ced3079a717ae53791986de2a94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35481045e9f77ced3079a717ae53791986de2a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
* 35481045e9f77ced3079a717ae53791986de2a94 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5158: [HUDI-3733] Adding HoodieFailedWritesCleaningPolicy for restore with hudi-cli
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5158:
URL: https://github.com/apache/hudi/pull/5158#issuecomment-1084010103
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474",
"triggerID" : "77bfef4579876bf79d8ed971946da7c15a1e80e5",
"triggerType" : "PUSH"
}, {
"hash" : "35481045e9f77ced3079a717ae53791986de2a94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7606",
"triggerID" : "35481045e9f77ced3079a717ae53791986de2a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77bfef4579876bf79d8ed971946da7c15a1e80e5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7474)
* 35481045e9f77ced3079a717ae53791986de2a94 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7606)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org