You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/01/14 05:05:15 UTC

[GitHub] [incubator-doris] Sunt-ing opened a new pull request #5241: Update README.md: a reword suggestion

Sunt-ing opened a new pull request #5241:
URL: https://github.com/apache/incubator-doris/pull/5241


   A reword suggestion that makes the words more friendly
   
   ## Proposed changes
   A reword suggestion. Change 
   from "You must be install following softwares:"
       to "You should install the following softwares:"
   
   ## Types of changes
   - [] Bugfix (non-breaking change which fixes an issue)
   - [] New feature (non-breaking change which adds functionality)
   - [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [x] Documentation Update (if none of the other choices apply)
   - [] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   The PR is very clear, and thus I think no issue is needed.
   It's a simple reword suggestion, which will not break our project.
   
   ## Further comments
   It's very straightforward, so I don't think any additional comment is needed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] Sunt-ing commented on pull request #5241: [Doc] Update README.md: a reword suggestion

Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #5241:
URL: https://github.com/apache/incubator-doris/pull/5241#issuecomment-759935419


   Thanks! @yangzhg 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yangzhg merged pull request #5241: [Doc] Update README.md: a reword suggestion

Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #5241:
URL: https://github.com/apache/incubator-doris/pull/5241


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5241: [Doc] Update README.md: a reword suggestion

Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5241:
URL: https://github.com/apache/incubator-doris/pull/5241#discussion_r557048988



##########
File path: README.md
##########
@@ -117,7 +117,7 @@ After successfully building, it will install binary files in the directory `outp
 
 #### Prerequisites
 
-You must be install following softwares:
+You should install the following softwares:
 
 ```
 GCC 5.3.1+, Oracle JDK 1.8+, Python 2.7+, Apache Maven 3.5+, CMake 3.4.3+

Review comment:
       ```suggestion
   GCC 7.3.0+, Oracle JDK 1.8+, Python 2.7+, Apache Maven 3.5+, CMake 3.4.3+
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org