You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 17:56:45 UTC

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2435: MINOR: Improve error messages for GROUP BY / HAVING queries

andygrove opened a new pull request, #2435:
URL: https://github.com/apache/arrow-datafusion/pull/2435

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Before this change, we get error messages like `Projection references non-aggregate values` without any context, which are not super helpful.
   
   With this change, we get:
   
   ```
   Projection references non-aggregate values: Expression #person.first_name could not be resolved from available columns: #MAX(person.age)
   ```
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Improve error messages and update tests.
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   Yes, better error messages.
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #2435: MINOR: Improve error messages for GROUP BY / HAVING queries

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2435:
URL: https://github.com/apache/arrow-datafusion/pull/2435#issuecomment-1116386270

   @comphead you may find these changes helpful


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 merged pull request #2435: MINOR: Improve error messages for GROUP BY / HAVING queries

Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #2435:
URL: https://github.com/apache/arrow-datafusion/pull/2435


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org