You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/06/26 20:00:44 UTC
[kudu-CR] KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10826
Change subject: KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
......................................................................
KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
Fixes a potential NPE on non-decimal columns and adds
tests to prevent the issue in the future.
Change-Id: Ica7afcbbbd9197e6ffd34761a5298f29e7306dd6
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
2 files changed, 50 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/10826/1
--
To view, visit http://gerrit.cloudera.org:8080/10826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica7afcbbbd9197e6ffd34761a5298f29e7306dd6
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10826 )
Change subject: KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
......................................................................
KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
Fixes a potential NPE on non-decimal columns and adds
tests to prevent the issue in the future.
Change-Id: Ica7afcbbbd9197e6ffd34761a5298f29e7306dd6
Reviewed-on: http://gerrit.cloudera.org:8080/10826
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
2 files changed, 50 insertions(+), 22 deletions(-)
Approvals:
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica7afcbbbd9197e6ffd34761a5298f29e7306dd6
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Chris George <ch...@rms.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10826 )
Change subject: KUDU-2471: Fix ColumnSchema.equals NPE with non-Decimal columns
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7afcbbbd9197e6ffd34761a5298f29e7306dd6
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Chris George <ch...@rms.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 26 Jun 2018 22:04:01 +0000
Gerrit-HasComments: No