You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ic...@apache.org on 2016/06/13 09:31:09 UTC
svn commit: r1748155 - /httpd/httpd/trunk/modules/dav/main/mod_dav.h
Author: icing
Date: Mon Jun 13 09:31:09 2016
New Revision: 1748155
URL: http://svn.apache.org/viewvc?rev=1748155&view=rev
Log:
mod_dav: making mod_dav.h compile with clang again
Modified:
httpd/httpd/trunk/modules/dav/main/mod_dav.h
Modified: httpd/httpd/trunk/modules/dav/main/mod_dav.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/mod_dav.h?rev=1748155&r1=1748154&r2=1748155&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/dav/main/mod_dav.h (original)
+++ httpd/httpd/trunk/modules/dav/main/mod_dav.h Mon Jun 13 09:31:09 2016
@@ -486,7 +486,7 @@ typedef struct
} dav_get_props_result;
/* holds the contents of a <response> element */
-typedef struct dav_response
+struct dav_response
{
const char *href; /* always */
const char *desc; /* optional description at <response> level */
@@ -497,7 +497,7 @@ typedef struct dav_response
int status;
struct dav_response *next;
-} dav_response;
+};
typedef struct
{
Re: svn commit: r1748155 -
/httpd/httpd/trunk/modules/dav/main/mod_dav.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/13/2016 11:53 AM, Stefan Eissing wrote:
> Hmm, there is a "typedef struct dav_response dav_response" further and the new typedef of the same struct gave an error in clang. I thought this was the best way to fix this...
I missed that "typedef struct dav_response dav_response". All good. Sorry for the noise.
Regards
R�diger
Re: svn commit: r1748155 - /httpd/httpd/trunk/modules/dav/main/mod_dav.h
Posted by Stefan Eissing <st...@greenbytes.de>.
Hmm, there is a "typedef struct dav_response dav_response" further and the new typedef of the same struct gave an error in clang. I thought this was the best way to fix this...
-Stefan
> Am 13.06.2016 um 11:42 schrieb Ruediger Pluem <rp...@apache.org>:
>
>
>
> On 06/13/2016 11:31 AM, icing@apache.org wrote:
>> Author: icing
>> Date: Mon Jun 13 09:31:09 2016
>> New Revision: 1748155
>>
>> URL: http://svn.apache.org/viewvc?rev=1748155&view=rev
>> Log:
>> mod_dav: making mod_dav.h compile with clang again
>>
>> Modified:
>> httpd/httpd/trunk/modules/dav/main/mod_dav.h
>>
>> Modified: httpd/httpd/trunk/modules/dav/main/mod_dav.h
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/mod_dav.h?rev=1748155&r1=1748154&r2=1748155&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/dav/main/mod_dav.h (original)
>> +++ httpd/httpd/trunk/modules/dav/main/mod_dav.h Mon Jun 13 09:31:09 2016
>> @@ -486,7 +486,7 @@ typedef struct
>> } dav_get_props_result;
>>
>> /* holds the contents of a <response> element */
>> -typedef struct dav_response
>> +struct dav_response
>
> Shouldn't that be
>
> typedef struct
>
>> {
>> const char *href; /* always */
>> const char *desc; /* optional description at <response> level */
>> @@ -497,7 +497,7 @@ typedef struct dav_response
>> int status;
>>
>> struct dav_response *next;
>> -} dav_response;
>
> and this line kept
>
> Regards
>
> Rüdiger
Re: svn commit: r1748155 -
/httpd/httpd/trunk/modules/dav/main/mod_dav.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/13/2016 11:31 AM, icing@apache.org wrote:
> Author: icing
> Date: Mon Jun 13 09:31:09 2016
> New Revision: 1748155
>
> URL: http://svn.apache.org/viewvc?rev=1748155&view=rev
> Log:
> mod_dav: making mod_dav.h compile with clang again
>
> Modified:
> httpd/httpd/trunk/modules/dav/main/mod_dav.h
>
> Modified: httpd/httpd/trunk/modules/dav/main/mod_dav.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/mod_dav.h?rev=1748155&r1=1748154&r2=1748155&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/dav/main/mod_dav.h (original)
> +++ httpd/httpd/trunk/modules/dav/main/mod_dav.h Mon Jun 13 09:31:09 2016
> @@ -486,7 +486,7 @@ typedef struct
> } dav_get_props_result;
>
> /* holds the contents of a <response> element */
> -typedef struct dav_response
> +struct dav_response
Shouldn't that be
typedef struct
> {
> const char *href; /* always */
> const char *desc; /* optional description at <response> level */
> @@ -497,7 +497,7 @@ typedef struct dav_response
> int status;
>
> struct dav_response *next;
> -} dav_response;
and this line kept
Regards
R�diger