You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/07 16:39:30 UTC

[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon

vivekratnavel opened a new pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414
 
 
   ## What changes were proposed in this pull request?
   
   New addition of UI page for listing Datanodes in Recon web app.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2827
   
   ## How was this patch tested?
   
   This patch was tested by running the react app with mock api server.
   ```
   cd hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web
   yarn install
   yarn run dev
   ```
   
   A screen-shot of the new Datanodes page is attached below:
   <img width="1680" alt="Screen Shot 2020-01-07 at 10 06 45 PM" src="https://user-images.githubusercontent.com/1051198/71911615-095c7400-319a-11ea-9bc8-f2211feedc9e.png">
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek commented on a change in pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon

Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414#discussion_r364221600
 
 

 ##########
 File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/Datanodes/Datanodes.tsx
 ##########
 @@ -17,16 +17,171 @@
  */
 
 import React from 'react';
+import axios from 'axios';
+import {Table, Icon, Progress} from 'antd';
+import prettyBytes from 'pretty-bytes';
+import './Datanodes.less';
+import {PaginationConfig} from "antd/lib/pagination";
+import moment from 'moment';
+import {getCapacityPercent} from "../../utils/common";
 
-export const Datanodes: React.FC = () => {
-  return (
-      <div>
-        <div className="page-header">
-          Datanodes
-        </div>
-        <div className="content-div">
-          Datanodes content
-        </div>
-      </div>
-  );
+export type DatanodeStatus = "HEALTHY" | "STALE" | "DEAD" | "DECOMMISSIONING" | "DECOMMISSIONED";
 
 Review comment:
   FYI: it will be changed after merging HDDS-1880-Decom to two different state flag: HELTHY / STALE / DEAD and IN_SERVICE / DECOMMISSIONING/ED] / MAINTENANCE/IN_MAINTENANCE). Not actionable right now only FYI if you are thinking about long-term design.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #414: HDDS-2827. Add initial UI of Datanodes in Recon

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414#issuecomment-572033398
 
 
   @avijayanhwx Yes. Sorting can be enabled anytime. It is disabled for time being since we need to eventually support server side sort, filter and pagination. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek closed pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon

Posted by GitBox <gi...@apache.org>.
elek closed pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #414: HDDS-2827. Add initial UI of Datanodes in Recon

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414#issuecomment-571725789
 
 
   @vivekratnavel The UI looks good to me. Does this table widget currently include sorting by a specific column's values?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #414: HDDS-2827. Add initial UI of Datanodes in Recon

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414#issuecomment-571668314
 
 
   @elek @avijayanhwx Please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #414: HDDS-2827. Add initial UI of Datanodes in Recon
URL: https://github.com/apache/hadoop-ozone/pull/414#discussion_r364341881
 
 

 ##########
 File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/Datanodes/Datanodes.tsx
 ##########
 @@ -17,16 +17,171 @@
  */
 
 import React from 'react';
+import axios from 'axios';
+import {Table, Icon, Progress} from 'antd';
+import prettyBytes from 'pretty-bytes';
+import './Datanodes.less';
+import {PaginationConfig} from "antd/lib/pagination";
+import moment from 'moment';
+import {getCapacityPercent} from "../../utils/common";
 
-export const Datanodes: React.FC = () => {
-  return (
-      <div>
-        <div className="page-header">
-          Datanodes
-        </div>
-        <div className="content-div">
-          Datanodes content
-        </div>
-      </div>
-  );
+export type DatanodeStatus = "HEALTHY" | "STALE" | "DEAD" | "DECOMMISSIONING" | "DECOMMISSIONED";
 
 Review comment:
   Thanks @elek for the information. I will keep track of HDDS-1880-Decom 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org