[GitHub] [accumulo] ddanielr commented on a diff in pull request #3765: Handles exceptions during close

["ddanielr (via GitHub)" <gi...@apache.org>]

ddanielr commented on code in PR #3765:
URL: https://github.com/apache/accumulo/pull/3765#discussion_r1333193512


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java:
##########
@@ -238,10 +238,16 @@ private SortedKeyValueIterator<Key,Value> createIterator() throws IOException {
   public void close(boolean sawErrors) {
 
     if (memIters != null) {
+      log.debug("Returning mem iterators");
       tablet.returnMemIterators(memIters);
       memIters = null;
-      tablet.returnFilesForScan(fileReservationId);
-      fileReservationId = -1;
+      log.debug("Returning files for scanning");
+      try {
+        tablet.returnFilesForScan(fileReservationId);
+        fileReservationId = -1;
+      } catch (IllegalArgumentException | IllegalStateException e) {
+        log.debug("Error Returning files for scanning {}", e.getMessage());

Review Comment:
   Changes applied



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org