You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:44:54 UTC

[GitHub] [accumulo] jmark99 commented on a diff in pull request #2558: Specify when return values are unused

jmark99 commented on code in PR #2558:
URL: https://github.com/apache/accumulo/pull/2558#discussion_r841695394


##########
test/src/main/java/org/apache/accumulo/test/shell/ShellServerIT.java:
##########
@@ -1460,7 +1461,9 @@ public void listscans() throws Exception {
       SlowIterator.setSleepTime(cfg, 500);
       s.addScanIterator(cfg);
 
-      Thread thread = new Thread(() -> Iterators.size(s.iterator()));
+      var iterSize = new AtomicInteger(0);
+      Thread thread = new Thread(() -> iterSize.set(Iterators.size(s.iterator())));
+      assertTrue(iterSize.get() > 0);

Review Comment:
   Replaced with while-has-next-call-next loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org