[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call from org.apache.hadoop.record package in MR.

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138232#comment-13138232 ] 

Hadoop QA commented on MAPREDUCE-3302:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501270/MAPREDUCE-3302.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1190//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1190//console

This message is automatically generated.
                
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3302
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: client
>    Affects Versions: 0.24.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
>   /**
>    * verify that hash equals to HMacHash(msg)
>    * @param newHash
>    * @return true if is the same
>    */
>   private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
>     byte[] msg_hash = generateByteHash(msg, key);
>     return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
>   }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
>   public static int compareBytes(byte[] b1, int s1, int l1,
>                                  byte[] b2, int s2, int l2) {
>     return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
>   }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira