You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/02/08 16:02:08 UTC

[GitHub] ocket8888 opened a new pull request #3313: Ort.py environment variables

ocket8888 opened a new pull request #3313: Ort.py environment variables
URL: https://github.com/apache/trafficcontrol/pull/3313
 
 
   ## What does this PR do?
   The Python implementation of ORT will now use the semi-standard environment variables:
   
   TO_URL
       Specifies the URL/hostname of the Traffic Ops server, optionally with a port (must match `(?i:https?://)?\w+(\.\w+)*(:\d+)?` )
   TO_USER
      Specifies the name of the user as whom to authenticate with Traffic Ops
   TO_PASSWORD
       Specifies the password of the user as whom to authenticate with Traffic Ops
   
   This PR adds a new call signature to ORT.py - in addition to the old, Perl-compatible(ish) call signature - wherein specification of these pieces of information is optional when these environment variables are defined. They can also be overridden when they **are** defined by using the new `--to_url`, `-u`/`--to_user`, and `-p`/`--to_password` options, respectively. This new call signature also makes the log level optional (provided by the `-l`/`--log_level` option), and it will now default to `WARN`.
   
   ## Which TC components are affected by this PR?
   
   - [x] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [x] Traffic Ops ORT (Python)
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _________
   
   ## What is the best way to verify this PR?
   Define those environment variables and verify that
   
   1. When using the old call signature, they are ignored and operations proceed normally
   2. When using the new call signature, they are used and operations proceed normally
   3. When using the new call signature, they can be overridden by command-line options and operations proceed normally.
   
   This PR also includes updates to the documentation that should go into greater detail regarding the command line options allowed, so feel free to build and look at that if you need more information
   
   ## Check all that apply
   
   - [ ] This PR includes tests
   - [x] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services