You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/02 04:07:03 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #943: Refine the github related setting

xiaoxiang781216 opened a new pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943


   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #943: Refine the github related setting

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943#discussion_r418918269



##########
File path: .asf.yaml
##########
@@ -14,9 +14,5 @@ github:
     - mcu
     - microcontroller
   enabled_merge_buttons:
-    # enable squash button:
-    squash:  true

Review comment:
       I believe squashing can come in handy.
   But if you want to keep it in the contributor's hand, that's okay with me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #943: Refine the github related setting

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943#discussion_r418907151



##########
File path: .asf.yaml
##########
@@ -14,9 +14,5 @@ github:
     - mcu
     - microcontroller
   enabled_merge_buttons:
-    # enable squash button:
-    squash:  true

Review comment:
       Should we set these to false instead of relying on the default behaviour?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #943: Refine the github related setting

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943#discussion_r418918757



##########
File path: .asf.yaml
##########
@@ -14,9 +14,5 @@ github:
     - mcu
     - microcontroller
   enabled_merge_buttons:
-    # enable squash button:
-    squash:  true

Review comment:
       > elieve squashing can come in handy.
   
   We can ask contributor to do squash if need. In this way, contributor will learn how to organize the patch series in a better way and apply the knowledge in the furture PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #943: Refine the github related setting

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943#discussion_r418918757



##########
File path: .asf.yaml
##########
@@ -14,9 +14,5 @@ github:
     - mcu
     - microcontroller
   enabled_merge_buttons:
-    # enable squash button:
-    squash:  true

Review comment:
       > elieve squashing can come in handy.
   
   We can ask contributor to do squash if need. Contributor will learn how to organize the patch series in a better way and apply the knowledge in the furture PR. In this way, it may need more work initially, but will save the time in later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #943: Refine the github related setting

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943#discussion_r418918271



##########
File path: .asf.yaml
##########
@@ -14,9 +14,5 @@ github:
     - mcu
     - microcontroller
   enabled_merge_buttons:
-    # enable squash button:
-    squash:  true

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org