You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2011/06/30 01:40:15 UTC
svn commit: r1141330 -
/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/version/RequestCycleCachedResourceVersion.java
Author: pete
Date: Wed Jun 29 23:40:15 2011
New Revision: 1141330
URL: http://svn.apache.org/viewvc?rev=1141330&view=rev
Log:
WICKET-3846 remove unnecessary lookup
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/version/RequestCycleCachedResourceVersion.java
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/version/RequestCycleCachedResourceVersion.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/version/RequestCycleCachedResourceVersion.java?rev=1141330&r1=1141329&r2=1141330&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/version/RequestCycleCachedResourceVersion.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/version/RequestCycleCachedResourceVersion.java Wed Jun 29 23:40:15 2011
@@ -72,15 +72,15 @@ public class RequestCycleCachedResourceV
// retrieve cache from current request cycle
cache = requestCycle.getMetaData(CACHE_KEY);
- // create it on first call
+ // does cache exist within current request cycle?
if (cache == null)
{
+ // no, so create it
requestCycle.setMetaData(CACHE_KEY, cache = Generics.newHashMap());
}
-
- // lookup timestamp from cache (may contain NULL values which are valid)
- if (cache.containsKey(resourceReference))
+ else if (cache.containsKey(resourceReference))
{
+ // lookup timestamp from cache (may contain NULL values which are valid)
return cache.get(resourceReference);
}
}